From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6392907056098050048 Date: Thu, 2 Mar 2017 06:48:13 -0800 (PST) From: SIMRAN SINGHAL To: outreachy-kernel Cc: singhalsimran0@gmail.com, marvin24@gmx.de, gregkh@linuxfoundation.org, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20170302142418.GA16773@singhal-Inspiron-5558> Subject: Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGE checkpatch checks MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_905_1933106270.1488466093680" X-Google-Token: EK3h4MUF0aGjAX5xXUQ0 X-Google-IP: 14.139.82.6 ------=_Part_905_1933106270.1488466093680 Content-Type: multipart/alternative; boundary="----=_Part_906_963170190.1488466093680" ------=_Part_906_963170190.1488466093680 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote: > > > > On Thu, 2 Mar 2017, simran singhal wrote: > > > Resolve strict checkpatch USLEEP_RANGE checks by converting delays and > > sleeps as described in ./Documentation/timers/timers-howto.txt. > > > > CHECK: usleep_range is preferred over udelay; see Documentation/ > > timers/timers-howto.txt > > > > Signed-off-by: simran singhal > > > --- > > drivers/staging/nvec/nvec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > > index c1feccf..cd35e64 100644 > > --- a/drivers/staging/nvec/nvec.c > > +++ b/drivers/staging/nvec/nvec.c > > @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, void > *dev) > > break; > > case 2: /* first byte after command */ > > if (status == (I2C_SL_IRQ | RNW | RCVD)) { > > - udelay(33); > > + usleep_range(33, 100); > > How did you choose the upper limit. > > I believe that Greg previously suggested not to make these changes if you > have no way to test them. > > Julia, After going through the reply given by Nicholas Mc Guire https://www.mail-archive.com/kernelnewbies@kernelnewbies.org/msg16464.html in this reply he has mentioned that even the range of 10 microsecond is enough, so I prefer to take 100 as upper limit. Simran julia > > > > if (nvec->rx->data[0] != 0x01) { > > dev_err(nvec->dev, > > "Read without prior read > command\n"); > > @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void > *dev) > > * We experience less incomplete messages with this delay than > without > > * it, but we don't know why. Help is appreciated. > > */ > > - udelay(100); > > + usleep_range(100, 200); > > > > return IRQ_HANDLED; > > } > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com . > > To post to this group, send email to outreach...@googlegroups.com > . > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20170302142418.GA16773%40singhal-Inspiron-5558. > > > For more options, visit https://groups.google.com/d/optout. > > > ------=_Part_906_963170190.1488466093680 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30,= Julia Lawall wrote:


On Thu, 2 Mar 2017, simran singhal wrote:

> Resolve strict checkpatch USLEEP_RANGE checks by converting delays= and
> sleeps as described in ./Documentation/timers/timers-howto.tx= t.
>
> CHECK: usleep_range is preferred over udelay; see Documentation/
> timers/timers-howto.txt
>
> Signed-off-by: simran singhal <singhal...@gmail.com>
> ---
> =C2=A0drivers/staging/nvec/nvec.c | 4 ++--
> =C2=A01 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nv= ec.c
> index c1feccf..cd35e64 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, voi= d *dev)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0break;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case 2:=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0/* first byte after command */
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (status =3D=3D (I2C_SL_IRQ | RNW | R= CVD)) {
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0udelay(33);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0usleep_range(33, 100);

How did you choose the upper limit.

I believe that Greg previously suggested not to make these changes if y= ou
have no way to test them.

Julia, After going through the reply given by=C2=A0Ni= cholas Mc Guire=C2=A0
https://www.mail-archive.com/kernelnewbies@= kernelnewbies.org/msg16464.html
in this reply he has mentione= d that even the range of 10 microsecond is enough,
so I prefe= r to take 100 as upper limit. =C2=A0
=C2=A0
Simran

julia


> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0if (nvec->rx->data[0] !=3D 0x01) {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dev_err(nvec-= >dev,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"Read without prior read command\n= ");
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, voi= d *dev)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * We experi= ence less incomplete messages with this delay than without
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * it, but w= e don't know why. Help is appreciated.
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udelay(100);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0usleep_range(100,= 200);
>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return IRQ_H= ANDLED;
> =C2=A0}
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google= Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, = send an email to outreachy-kern...@googlegroups.com.
> To post to this group, send email to outreach...@googlegroups.com<= /a>.
> To view this discussion on the web visit https://groups.google.com/d/msg= id/outreachy-kernel/20170302142418.GA16773%40singhal-Inspiron-555= 8.
> For more options, visit https://groups.go= ogle.com/d/optout.
>
------=_Part_906_963170190.1488466093680-- ------=_Part_905_1933106270.1488466093680--