From: Waiman Long <llong@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Chen Ridong <chenridong@huawei.com>
Subject: Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c
Date: Thu, 16 Jan 2025 08:40:56 -0500 [thread overview]
Message-ID: <b90d0be9-b970-442d-874d-1031a63d1058@redhat.com> (raw)
In-Reply-To: <20250116095656.643976-1-mkoutny@suse.com>
On 1/16/25 4:56 AM, Michal Koutný wrote:
> The cpuset file is a legacy attribute that is bound primarily to cpuset
> v1 (and it'd be equal to effective /proc/$pid/cgroup path on the unified
> hierarchy).
>
> Followup to commit b0ced9d378d49 ("cgroup/cpuset: move v1 interfaces to
> cpuset-v1.c") and hide CONFIG_PROC_PID_CPUSET under CONFIG_CPUSETS_V1.
> Drop an obsolete comment too.
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
I do have some reservation in taking out /proc/<pid>/cpuset by default
as CPUSETS_V1 is off by default. This may break some existing user scripts.
Also the statement that the cpuset file is the same as the path in
cgroup file in unified hierarchy is not true if that cgroup doesn't have
cpuset enabled.
Cheers,
Longman
next prev parent reply other threads:[~2025-01-16 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 9:56 [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c Michal Koutný
2025-01-16 13:40 ` Waiman Long [this message]
2025-01-16 14:05 ` Michal Koutný
2025-01-16 17:25 ` Tejun Heo
2025-01-16 19:15 ` Waiman Long
2025-01-16 19:38 ` Tejun Heo
2025-01-17 10:44 ` [PATCH v2] " Michal Koutný
2025-01-17 14:39 ` Waiman Long
2025-01-17 16:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b90d0be9-b970-442d-874d-1031a63d1058@redhat.com \
--to=llong@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.