From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A5A147C60 for ; Wed, 17 Apr 2024 15:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713367840; cv=none; b=o0YJGExT3uq1H6TZ8lhEU6ei1/Rk1L2dq5uzFUxt9YdDQjqjH4oQ7qPtuPDRmOsSZeLw5I6E4Oc70HhCsoTYmn2TzeAo+F+7TMeaaGuYVVBMJDnQlqkkz2ipz6qSTNyDlwEG5Ojc+7mKmEbZo7pmKwYoSKFhGHW7NchvA3LwM9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713367840; c=relaxed/simple; bh=8L9FWH/LHbEyj85WryAl1y2Vb4mXu+cGmOWVxsOrNHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ltjETwn7paIRInHJPUdIZVZR9/hx8LcwYXbnZEJYYI/3644uHDIXjCekKvcDRtUHLXdqFvhh/OhSxGPnIl1uT61B99P6R+W/bfVsDxOU8UotZGuojlR4pfSlhrYVHzN09llW7bL4T0KlFyD+HklIPCgF3KUiJWxgGyZoo9VPQRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=z4k6Q+0y; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="z4k6Q+0y" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 138CD8841D; Wed, 17 Apr 2024 17:30:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1713367830; bh=1KtpGSfLviXFz3BNKiwi3I/lwFR3Jar+xTmmX6ZHb3g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=z4k6Q+0yfGx/89jLtjQJ0Kedqp1V3qyJ8JPo8sjpHVXt40Sq+EYKXWEkoZXvS95B+ 50C/96VROErYpWOgXyt9Lx4zrnDlAmiChVPwWCSvbvjZP3Dl0qxhYwG6PVxGXXf8Lw 2JMBXRGLDfSaH4zMM7o04EqwPZOOIbCCrKIzMw8R6nZ1ZNtz2/Em3lytVgZZpw8spp sjYLRQyOG2gLKCc+IcrKoThUoTR1U/vRWraDKCPDt3D/oShmJ8+F9oWv8PeGm+kKNQ nrEaPK3bnf7XFLDtEWeipa9npHo1d+wgvU8Chp1DI2295XPxQg/KCgaRS9BnDjkhaV VOp4+8J5wtSkQ== Message-ID: Date: Wed, 17 Apr 2024 13:06:31 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock To: Ahmad Fatoum , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , Paul Elder , imx@lists.linux.dev, Laurent Pinchart , Pengutronix Kernel Team , Shawn Guo References: <20240416141914.9375-1-marex@denx.de> <352388ee-a267-4c1f-b968-e1a7709d46ea@pengutronix.de> <6872097d-b1c8-40c0-8392-28c351dad3dc@pengutronix.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <6872097d-b1c8-40c0-8392-28c351dad3dc@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/17/24 12:17 PM, Ahmad Fatoum wrote: > On 17.04.24 12:14, Ahmad Fatoum wrote: >> On 16.04.24 16:19, Marek Vasut wrote: >>> Configure both CSI2 assigned-clock-rates the same way. >>> There does not seem to be any reason for keeping the >>> two CSI2 pixel clock set to different frequencies. >>> >>> This also reduces first CSI2 clock from overdrive mode >>> frequency which is 500 MHz down below the regular mode >>> frequency of 400 MHz. >>> >>> Signed-off-by: Marek Vasut >> >> Reviewed-by: Ahmad Fatoum > > I see now that the node has a clock-frequency = <500000000>; still. > This should be lowered too, shouldn't it? Oh, right, good catch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C61EBC4345F for ; Wed, 17 Apr 2024 15:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=80dWijuSEIpNfTVobAynvL2XHgdKrVKWByY2+V4sHAI=; b=kB0c1GPtcA+zBO pdrRlTZ3UvnWpg1jbJ15O9OPQumZQLISNML77vY9ceHbqPKMic8IDhUo2AKQasadB/ueYskf22gps 8sgh0x48uFSt+LrQmpSFSi+uNYrSnb9e/snD0hVJCNa35tjEQjZ65W/ph71EO+Xr0SlJeJKl48+Rq +iGFQArgvo4SQTDEWjan3jSThUgdOV2hr45enDqTke1AfKYe/9+T8V/AFFtiIfYzLsNw2yLBOA2CZ Ml/TSKBl9/wfa7L2RvNguFhpttWjuxg4cyICwjP2veY2HqBrCDgv4e8ogHn7Lfu4gmsCZG3masWgC 4l324IyLjQbJep7L3afA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7F8-0000000GauD-3v42; Wed, 17 Apr 2024 15:30:38 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7F6-0000000GaqM-35gB for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 15:30:38 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 138CD8841D; Wed, 17 Apr 2024 17:30:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1713367830; bh=1KtpGSfLviXFz3BNKiwi3I/lwFR3Jar+xTmmX6ZHb3g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=z4k6Q+0yfGx/89jLtjQJ0Kedqp1V3qyJ8JPo8sjpHVXt40Sq+EYKXWEkoZXvS95B+ 50C/96VROErYpWOgXyt9Lx4zrnDlAmiChVPwWCSvbvjZP3Dl0qxhYwG6PVxGXXf8Lw 2JMBXRGLDfSaH4zMM7o04EqwPZOOIbCCrKIzMw8R6nZ1ZNtz2/Em3lytVgZZpw8spp sjYLRQyOG2gLKCc+IcrKoThUoTR1U/vRWraDKCPDt3D/oShmJ8+F9oWv8PeGm+kKNQ nrEaPK3bnf7XFLDtEWeipa9npHo1d+wgvU8Chp1DI2295XPxQg/KCgaRS9BnDjkhaV VOp4+8J5wtSkQ== Message-ID: Date: Wed, 17 Apr 2024 13:06:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock To: Ahmad Fatoum , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , Paul Elder , imx@lists.linux.dev, Laurent Pinchart , Pengutronix Kernel Team , Shawn Guo References: <20240416141914.9375-1-marex@denx.de> <352388ee-a267-4c1f-b968-e1a7709d46ea@pengutronix.de> <6872097d-b1c8-40c0-8392-28c351dad3dc@pengutronix.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <6872097d-b1c8-40c0-8392-28c351dad3dc@pengutronix.de> X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_083036_992877_2855AA68 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/17/24 12:17 PM, Ahmad Fatoum wrote: > On 17.04.24 12:14, Ahmad Fatoum wrote: >> On 16.04.24 16:19, Marek Vasut wrote: >>> Configure both CSI2 assigned-clock-rates the same way. >>> There does not seem to be any reason for keeping the >>> two CSI2 pixel clock set to different frequencies. >>> >>> This also reduces first CSI2 clock from overdrive mode >>> frequency which is 500 MHz down below the regular mode >>> frequency of 400 MHz. >>> >>> Signed-off-by: Marek Vasut >> >> Reviewed-by: Ahmad Fatoum > > I see now that the node has a clock-frequency = <500000000>; still. > This should be lowered too, shouldn't it? Oh, right, good catch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel