All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	Adam Duskett <adam.duskett@amarulasolutions.com>,
	Daniel Lang <dalang@gmx.at>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Romain Naour <romain.naour@gmail.com>,
	Valentin Korenblit <valentinkorenblit@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 5/6] package/{mesa3d, mesa3d-headers}: bump version to 24.3.3
Date: Mon, 27 Jan 2025 21:50:52 +0100	[thread overview]
Message-ID: <b91859d9482544da56b21180e00a3d19@free.fr> (raw)
In-Reply-To: <20250118083837.2883279-5-bernd@kuhls.net>

Hi Bernd,

Thank you for the patch.

On 18/01/2025 09:38, Bernd Kuhls wrote:
[...]
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index ce460c4475..bd46d4b893 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
[...]
> @@ -251,12 +261,32 @@ endif
>  ifeq ($(BR2_PACKAGE_LIBGLVND),y)
>  ifneq 
> ($(BR2_PACKAGE_MESA3D_OPENGL_GLX)$(BR2_PACKAGE_MESA3D_OPENGL_EGL),)
>  MESA3D_DEPENDENCIES += libglvnd
> -MESA3D_CONF_OPTS += -Dglvnd=true
> +MESA3D_CONF_OPTS += -Dglvnd=enabled
>  else
> -MESA3D_CONF_OPTS += -Dglvnd=false
> +MESA3D_CONF_OPTS += -Dglvnd=disabled
>  endif
>  else
> -MESA3D_CONF_OPTS += -Dglvnd=false
> +MESA3D_CONF_OPTS += -Dglvnd=disabled
>  endif
> 

Could you add a comment here, that host-mesa3d is needed by mesa3d
only when the Iris Gallium driver is enabled, please?
This will give a more info on the choice of config options here.

> +HOST_MESA3D_CONF_OPTS = \
> +	-Dglvnd=disabled \
> +	-Dgallium-drivers=iris \
> +	-Dgallium-vdpau=disabled \
> +	-Dplatforms= \
> +	-Dglx=disabled \
> +	-Dvulkan-drivers=""
> +
> +HOST_MESA3D_DEPENDENCIES = \
> +	host-libclc \
> +	host-libdrm \
> +	host-python-mako \
> +	host-python-pyyaml \
> +	host-spirv-tools

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-01-27 20:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-18  8:38 [Buildroot] [PATCH 1/6] package/libdrm: add host variant Bernd Kuhls
2025-01-18  8:38 ` [Buildroot] [PATCH 2/6] package/llvm-project/libclc: " Bernd Kuhls
2025-01-18  8:38 ` [Buildroot] [PATCH 3/6] package/spirv-llvm-translator: add target variant to provide LLVMSPIRVLib Bernd Kuhls
2025-01-18  8:38 ` [Buildroot] [PATCH 4/6] package/spirv-tools: add host variant Bernd Kuhls
2025-01-18  8:38 ` [Buildroot] [PATCH v4 5/6] package/{mesa3d, mesa3d-headers}: bump version to 24.3.3 Bernd Kuhls
2025-01-25 23:07   ` Fiona Klute via buildroot
2025-01-27 20:50   ` Julien Olivain [this message]
2025-01-18  8:38 ` [Buildroot] [PATCH 6/6] package/mesa3d: add option to enable VIRTIO vulkan driver Bernd Kuhls
2025-02-05 15:12   ` Thomas Petazzoni via buildroot
2025-01-25 23:02 ` [Buildroot] [PATCH 1/6] package/libdrm: add host variant Fiona Klute via buildroot
2025-01-27 20:43 ` Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b91859d9482544da56b21180e00a3d19@free.fr \
    --to=ju.o@free.fr \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=bernd@kuhls.net \
    --cc=buildroot@buildroot.org \
    --cc=dalang@gmx.at \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=romain.naour@gmail.com \
    --cc=valentinkorenblit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.