From: Martin KaFai Lau <martin.lau@linux.dev>
To: Yonghong Song <yonghong.song@linux.dev>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@meta.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Remove "&>" usage in the selftests
Date: Fri, 26 Jan 2024 22:14:10 -0800 [thread overview]
Message-ID: <b9216a64-0605-4386-963e-40555fdbf24b@linux.dev> (raw)
In-Reply-To: <879d5e4f-f20d-460b-9fb3-e362c0324ca2@linux.dev>
On 1/26/24 8:56 PM, Yonghong Song wrote:
>
> On 1/26/24 6:50 PM, Martin KaFai Lau wrote:
>> From: Martin KaFai Lau <martin.lau@kernel.org>
>>
>> In s390, CI reported that the sock_iter_batch selftest
>> hits this error very often:
>>
>> 2024-01-26T16:56:49.3091804Z Bind /proc/self/ns/net ->
>> /run/netns/sock_iter_batch_netns failed: No such file or directory
>> 2024-01-26T16:56:49.3149524Z Cannot remove namespace file
>> "/run/netns/sock_iter_batch_netns": No such file or directory
>> 2024-01-26T16:56:49.3772213Z test_sock_iter_batch:FAIL:ip netns add
>> sock_iter_batch_netns unexpected error: 256 (errno 0)
>>
>> It happens very often in s390 but Manu also noticed it happens very
>> sparsely in other arch also.
>>
>> It turns out the default dash shell does not recognize "&>"
>
> Not sure whether it is feasible or not. But is it possible
> for all our test VMs we run '/bin/bash' before everyting else
> so we have a uniform bash environment so we do not need to
> worry about other shells?
It was my initial thought also. I think it makes sense to use the minimal shell
feature such that it is more portable to different developer environments.
next prev parent reply other threads:[~2024-01-27 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 2:50 [PATCH bpf-next] selftests/bpf: Remove "&>" usage in the selftests Martin KaFai Lau
2024-01-27 4:56 ` Yonghong Song
2024-01-27 6:14 ` Martin KaFai Lau [this message]
2024-01-27 6:27 ` Yonghong Song
2024-01-27 6:08 ` Martin KaFai Lau
2024-01-29 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9216a64-0605-4386-963e-40555fdbf24b@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.