From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5BA3FC3 for ; Fri, 10 Sep 2021 23:48:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 53CDF611BF; Fri, 10 Sep 2021 23:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631317703; bh=3W+6f0wuipTibyjTQaN5vgjbRHyQ1UrUz0L6qzxUplo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KrXuEsLQIXYeh9eXjpq16ZYWxHkH1WKFaE5hG2+4bXOmbBKajE6+K36WBkyjLHeyS eKFv24TqMQXYQqVMk6mrx+RU19w1nOz9pH9XF2rOZ95sCLmquwI9BE51WUXEkYpaBF 8RkK8UfnGtQA3x4rATph8qC3uKDp9d2VQz/hAbFxMKvK4hDbew9QgCKm55he2f3w1v YrUP8LHlt6PJhToOv4sAeceahYMsxDn4WfexupxoLJM9GTQbht9lxUCWgUg8tzdWoI WHMy+eff9sVxectgaPmxHdq7NHT5WCoQXjgQNJARg7qXBmd4+Te7RyzLss+7SM92v6 5gpQvxgkkyESw== Subject: Re: [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR To: Nick Desaulniers , Andrew Morton Cc: Linus Torvalds , Rasmus Villemoes , Masahiro Yamada , Joe Perches , Arnd Bergmann , Stephen Rothwell , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Segher Boessenkool , Christophe Leroy , linuxppc-dev@lists.ozlabs.org References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-7-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: Date: Fri, 10 Sep 2021 16:48:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210910234047.1019925-7-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/10/2021 4:40 PM, Nick Desaulniers wrote: > Now that GCC 5.1 is the minimum supported version, we can drop this > workaround for older versions of GCC. This adversely affected clang, > too. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Segher Boessenkool > Cc: Christophe Leroy > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Nick Desaulniers > --- > arch/powerpc/include/asm/asm-const.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/powerpc/include/asm/asm-const.h b/arch/powerpc/include/asm/asm-const.h > index 0ce2368bd20f..dbfa5e1e3198 100644 > --- a/arch/powerpc/include/asm/asm-const.h > +++ b/arch/powerpc/include/asm/asm-const.h > @@ -12,16 +12,6 @@ > # define ASM_CONST(x) __ASM_CONST(x) > #endif > > -/* > - * Inline assembly memory constraint > - * > - * GCC 4.9 doesn't properly handle pre update memory constraint "m<>" > - * > - */ > -#if defined(GCC_VERSION) && GCC_VERSION < 50000 > -#define UPD_CONSTR "" > -#else > #define UPD_CONSTR "<>" > -#endif The only reason this exists is because of commit 592bbe9c505d ("powerpc/uaccess: Don't use "m<>" constraint with GCC 4.9"). It is probably just worth sinking "<>" into all of the callsites and removing UPD_CONSTR. > > #endif /* _ASM_POWERPC_ASM_CONST_H */ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A626C433EF for ; Fri, 10 Sep 2021 23:49:06 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9873261215 for ; Fri, 10 Sep 2021 23:49:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9873261215 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H5sz41GJVz2yPy for ; Sat, 11 Sep 2021 09:49:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KrXuEsLQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=nathan@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KrXuEsLQ; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H5syL3yzHz2xtS for ; Sat, 11 Sep 2021 09:48:26 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 53CDF611BF; Fri, 10 Sep 2021 23:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631317703; bh=3W+6f0wuipTibyjTQaN5vgjbRHyQ1UrUz0L6qzxUplo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KrXuEsLQIXYeh9eXjpq16ZYWxHkH1WKFaE5hG2+4bXOmbBKajE6+K36WBkyjLHeyS eKFv24TqMQXYQqVMk6mrx+RU19w1nOz9pH9XF2rOZ95sCLmquwI9BE51WUXEkYpaBF 8RkK8UfnGtQA3x4rATph8qC3uKDp9d2VQz/hAbFxMKvK4hDbew9QgCKm55he2f3w1v YrUP8LHlt6PJhToOv4sAeceahYMsxDn4WfexupxoLJM9GTQbht9lxUCWgUg8tzdWoI WHMy+eff9sVxectgaPmxHdq7NHT5WCoQXjgQNJARg7qXBmd4+Te7RyzLss+7SM92v6 5gpQvxgkkyESw== Subject: Re: [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR To: Nick Desaulniers , Andrew Morton References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-7-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: Date: Fri, 10 Sep 2021 16:48:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910234047.1019925-7-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , linuxppc-dev@lists.ozlabs.org, Arnd Bergmann , Masahiro Yamada , llvm@lists.linux.dev, Rasmus Villemoes , linux-kernel@vger.kernel.org, Paul Mackerras , Joe Perches , Linus Torvalds Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 9/10/2021 4:40 PM, Nick Desaulniers wrote: > Now that GCC 5.1 is the minimum supported version, we can drop this > workaround for older versions of GCC. This adversely affected clang, > too. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Segher Boessenkool > Cc: Christophe Leroy > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Nick Desaulniers > --- > arch/powerpc/include/asm/asm-const.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/powerpc/include/asm/asm-const.h b/arch/powerpc/include/asm/asm-const.h > index 0ce2368bd20f..dbfa5e1e3198 100644 > --- a/arch/powerpc/include/asm/asm-const.h > +++ b/arch/powerpc/include/asm/asm-const.h > @@ -12,16 +12,6 @@ > # define ASM_CONST(x) __ASM_CONST(x) > #endif > > -/* > - * Inline assembly memory constraint > - * > - * GCC 4.9 doesn't properly handle pre update memory constraint "m<>" > - * > - */ > -#if defined(GCC_VERSION) && GCC_VERSION < 50000 > -#define UPD_CONSTR "" > -#else > #define UPD_CONSTR "<>" > -#endif The only reason this exists is because of commit 592bbe9c505d ("powerpc/uaccess: Don't use "m<>" constraint with GCC 4.9"). It is probably just worth sinking "<>" into all of the callsites and removing UPD_CONSTR. > > #endif /* _ASM_POWERPC_ASM_CONST_H */ >