From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B80CEC04A68 for ; Wed, 27 Jul 2022 09:51:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE31D83B; Wed, 27 Jul 2022 11:50:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE31D83B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1658915509; bh=H6fYuC0QNly62Q6UUf4+k5qW/1r3OMVgEe3S6YkSsHc=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cWcgCKXHV2iLKjmvUHUqupf/xKMMub8/uh62RCYOvwDFvnojlNRl9Ebh+UMlZb4J3 WVfnft9ZyWO0t2LuAxcf+631elPgg1GjD0SoW/O6HeDSs7cAUaSshR7BLB5zMFp3WD fKjeBektQ6L+W6lgpg+E/KxwTy5VJ6rYh0YdU8uc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 752A7F80155; Wed, 27 Jul 2022 11:50:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A583F8015B; Wed, 27 Jul 2022 11:50:56 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C86E5F800FA for ; Wed, 27 Jul 2022 11:50:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C86E5F800FA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="aMLXa261" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26R4fJco006636; Wed, 27 Jul 2022 04:50:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=HM5eFBZGRCdHvLCsHt6IMA/yn3ZNWVn2pGGu0+bjhKQ=; b=aMLXa2610H3t15JJZd2/oDXNpeP6kE9XaYY4WUWkD7jAqFUL8YhzL6pZEdsRlj2hNeLL 2RXlz3W2uU9DseKxZh70Bb+si4TnQUAtBtF3ccKUakKqDN6GOeIXfH9Am4GXcVnemosD 0Elmh0RX2uA9isK78wK9QhclNP6XsnzdGDKOT4nqPr1a1uzb8CvYZ6+5DlfDi1zMFVls rH4ccCbad034zITNk2uFyMjOvPLmrX7B2HvDLVwLIC/u34YtbycLtUCOOHJYvaZZf79W TxvYCP2M8VHM59mbmAzbhKDUYnnKCV9j/bUUPn6sovp5P9+hP97i1EGcEZbIQ4hpE7ob kw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3hgddp4q3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jul 2022 04:50:45 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Wed, 27 Jul 2022 04:50:43 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.9 via Frontend Transport; Wed, 27 Jul 2022 04:50:43 -0500 Received: from [198.61.65.94] (unknown [198.61.65.94]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3C4272D4; Wed, 27 Jul 2022 09:50:43 +0000 (UTC) Message-ID: Date: Wed, 27 Jul 2022 10:50:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/2] Add support for CLSA0101 Content-Language: en-US To: Cameron Berkenpas , Jaroslav Kysela , Takashi Iwai References: <20220726101131.68058-1-tanureal@opensource.cirrus.com> <91e34de4-1c85-073f-9c24-ce3133394fe6@neo-zeon.de> From: Lucas tanure In-Reply-To: <91e34de4-1c85-073f-9c24-ce3133394fe6@neo-zeon.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: thaaJHwGFhnlMKE2LYvvBLI2rIGxQiKo X-Proofpoint-ORIG-GUID: thaaJHwGFhnlMKE2LYvvBLI2rIGxQiKo X-Proofpoint-Spam-Reason: safe Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/26/22 16:35, Cameron Berkenpas wrote: > Hello, > > I can confirm this does _not_ work. > > More specifically, with these patches, the original behavior still occurs: > 1. You get left channel audio from the right speaker only. Hi, yes, I did forgot the scan and multi instantiate part. I will send V2 with the fix. > 2. No sound at all after resuming from sleep. > 3. You get sound after resuming from hibernate, but only as described in > #1. This is a different issue, that will be fixed in the future. > > If you apply a patch like this: https://paste-bin.xyz/71355 > > You  get properly working audio until you put the laptop to sleep or > hibernate. Upon resuming from either state, you get no audio at all. > > On 7/26/22 03:11, Lucas Tanure wrote: >> Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. >> This patch has been tested using the CLSA0100, ensuring it >> doesn't break the sound for it. >> We appreciate it if someone with CLSA0101 could verify that this >> the patch works for them. >> >> Lucas Tanure (2): >>    ALSA: hda: cs35l41: Use the CS35L41 HDA internal define >>    ALSA: hda: cs35l41: Support CLSA0101 >> >>   sound/pci/hda/cs35l41_hda.c   | 67 +++++++++++++++++++++-------------- >>   sound/pci/hda/patch_realtek.c | 12 +++++++ >>   2 files changed, 53 insertions(+), 26 deletions(-) >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F1FC04A68 for ; Wed, 27 Jul 2022 09:51:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbiG0Jvg (ORCPT ); Wed, 27 Jul 2022 05:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbiG0Jvd (ORCPT ); Wed, 27 Jul 2022 05:51:33 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B2AC220E2 for ; Wed, 27 Jul 2022 02:51:32 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26R4fJco006636; Wed, 27 Jul 2022 04:50:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=HM5eFBZGRCdHvLCsHt6IMA/yn3ZNWVn2pGGu0+bjhKQ=; b=aMLXa2610H3t15JJZd2/oDXNpeP6kE9XaYY4WUWkD7jAqFUL8YhzL6pZEdsRlj2hNeLL 2RXlz3W2uU9DseKxZh70Bb+si4TnQUAtBtF3ccKUakKqDN6GOeIXfH9Am4GXcVnemosD 0Elmh0RX2uA9isK78wK9QhclNP6XsnzdGDKOT4nqPr1a1uzb8CvYZ6+5DlfDi1zMFVls rH4ccCbad034zITNk2uFyMjOvPLmrX7B2HvDLVwLIC/u34YtbycLtUCOOHJYvaZZf79W TxvYCP2M8VHM59mbmAzbhKDUYnnKCV9j/bUUPn6sovp5P9+hP97i1EGcEZbIQ4hpE7ob kw== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3hgddp4q3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jul 2022 04:50:45 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Wed, 27 Jul 2022 04:50:43 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.9 via Frontend Transport; Wed, 27 Jul 2022 04:50:43 -0500 Received: from [198.61.65.94] (unknown [198.61.65.94]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3C4272D4; Wed, 27 Jul 2022 09:50:43 +0000 (UTC) Message-ID: Date: Wed, 27 Jul 2022 10:50:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/2] Add support for CLSA0101 Content-Language: en-US To: Cameron Berkenpas , Jaroslav Kysela , Takashi Iwai CC: , , References: <20220726101131.68058-1-tanureal@opensource.cirrus.com> <91e34de4-1c85-073f-9c24-ce3133394fe6@neo-zeon.de> From: Lucas tanure In-Reply-To: <91e34de4-1c85-073f-9c24-ce3133394fe6@neo-zeon.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: thaaJHwGFhnlMKE2LYvvBLI2rIGxQiKo X-Proofpoint-ORIG-GUID: thaaJHwGFhnlMKE2LYvvBLI2rIGxQiKo X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/22 16:35, Cameron Berkenpas wrote: > Hello, > > I can confirm this does _not_ work. > > More specifically, with these patches, the original behavior still occurs: > 1. You get left channel audio from the right speaker only. Hi, yes, I did forgot the scan and multi instantiate part. I will send V2 with the fix. > 2. No sound at all after resuming from sleep. > 3. You get sound after resuming from hibernate, but only as described in > #1. This is a different issue, that will be fixed in the future. > > If you apply a patch like this: https://paste-bin.xyz/71355 > > You  get properly working audio until you put the laptop to sleep or > hibernate. Upon resuming from either state, you get no audio at all. > > On 7/26/22 03:11, Lucas Tanure wrote: >> Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. >> This patch has been tested using the CLSA0100, ensuring it >> doesn't break the sound for it. >> We appreciate it if someone with CLSA0101 could verify that this >> the patch works for them. >> >> Lucas Tanure (2): >>    ALSA: hda: cs35l41: Use the CS35L41 HDA internal define >>    ALSA: hda: cs35l41: Support CLSA0101 >> >>   sound/pci/hda/cs35l41_hda.c   | 67 +++++++++++++++++++++-------------- >>   sound/pci/hda/patch_realtek.c | 12 +++++++ >>   2 files changed, 53 insertions(+), 26 deletions(-) >> >