All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Anil Kaushik <anilkaushikwireless@gmail.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH iproute2-next 0/2] mptcp: limits: add subflow_retries
Date: Thu, 19 Nov 2026 19:54:18 +0100	[thread overview]
Message-ID: <b943c883-cff2-42ca-9299-729d8423f99e@kernel.org> (raw)
In-Reply-To: <20261119184507.1954726-1-anilkaushikwireless@gmail.com>

Hi Anil,

On 19/11/2026 19:45, Anil Kaushik wrote:
> This adds the new subflow-retries limit of the in-kernel path manager to
> "ip mptcp limits", as Matt suggested on the kernel series:
> 
> https://lore.kernel.org/mptcp/20261103085244.23064-1-anilkaushikwireless@gmail.com/
> 
> Patch 1 adds the new attribute to the copied uapi header. It is only
> needed until the iproute2 maintainers update the headers, once the
> kernel part is merged.
> 
> Patch 2 adds "subflow_retries" to "ip mptcp limits set" and "show", and
> to the man page.

I didn't review this in details, but I'm just thinking that you might
also want to expose the new limit_subflow_retries counter in ss.

Just note that ss.c is probably going to be split, see:

https://lore.kernel.org/20261119024049.3109143-1-stephen@networkplumber.org

(if you send a v2, please use [iproute2-mptcp] prefix, just not to
confuse with the ones that will be sent upstream)

> With this ip, "pm_netlink.sh -i" from the v15 kernel series fails the
> "set limits" check, because ip now shows the new limit. I have a fix for
> the selftest, which also runs the subflow-retries checks with ip. I can
> squash it in the pm_netlink.sh patch of the next version of the series.
Ah yes, good point. Yes, we will need it. I didn't review v15 yet, it
can wait or feel free to send a v16 if you already have it.

Note that the selftests ideally need to support older kernel version (so
without recent features) and older tools, e.g. IPRoute2 without your
patch. (except if thing get unreadable)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      parent reply	other threads:[~2026-11-19 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 18:45 [PATCH iproute2-next 0/2] mptcp: limits: add subflow_retries Anil Kaushik
2026-11-19 18:45 ` [PATCH iproute2-next 1/2] uapi: mptcp: add MPTCP_PM_ATTR_SUBFLOW_RETRIES Anil Kaushik
2026-11-19 18:45 ` [PATCH iproute2-next 2/2] mptcp: limits: add subflow_retries Anil Kaushik
2026-11-19 18:54 ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b943c883-cff2-42ca-9299-729d8423f99e@kernel.org \
    --to=matttbe@kernel.org \
    --cc=anilkaushikwireless@gmail.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.