From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: add a tracepoint for gpu
	frequency changes
Date: Sun, 02 Sep 2012 08:41:21 +0100
Message-ID: <b94cdc$6f4l79@fmsmga001.fm.intel.com>
References: <1346326008-11186-1-git-send-email-daniel.vetter@ffwll.ch>
	<06ae216a0855cba921de7ebdcc75acb4@bwidawsk.net>
	<504253E7.9050207@linux.intel.com>
	<92c9f07349e6acf42f5ed7182046aff2@bwidawsk.net>
	<6c3329$5pqra1@orsmga002.jf.intel.com>
	<134cae9b5b455bbcd2a3d2bb2e169938@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <134cae9b5b455bbcd2a3d2bb2e169938@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Arjan van de Ven <arjan@linux.intel.com>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Sat, 01 Sep 2012 18:16:52 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On 2012-09-01 12:22, Chris Wilson wrote:
> > On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky <ben@bwidawsk.net> 
> > wrote:
> >> I have no problem with Daniel's patch. It's just a matter of cutting
> >> through some scheduler BS of "when the GPU wants to change 
> >> frequency"
> >> vs. "when we actually change the GPU frequency." I think *both* are
> >> interesting.
> >
> > We already trace the interrupt, which has been invaluable in
> > debugging. And there is no other source currently... :)
> > -Chris
> 
> No we do not trace it (/me is looking on cgit, so perhaps a bit error 
> prone). Sure we trace GT interrupts, but not pm interrupts (again, 
> unless I am missing something via code browsing on the web).

Oh we definitely do otherwise it would have been a bit difficult to have
noticed that we woke up every 10ms to service a PM event that we then
ignore...

> Furthermore, even if we have added a generic interrupt trace event and 
> I've missed it: I think it's still nice to have a power/performance 
> specific one for users like powerTOP, as opposed to driver developers.

As complete BS as GPU op/s? If you can find a tracepoint that is
actionable from within powertop, go for it.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre