From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v3
Date: Fri, 02 Nov 2012 13:37:58 +0000 [thread overview]
Message-ID: <b94cdc$76je6l@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1351723265-4086-2-git-send-email-jbarnes@virtuousgeek.org>
On Wed, 31 Oct 2012 15:41:03 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Communicating via the mailbox registers with the PCU can take quite
> awhile. And updating the ring frequency or enabling turbo is not
> something that needs to happen synchronously, so take it out of our init
> and resume paths to speed things up (~200ms on my T420).
>
> v2: add comment about why we use a work queue (Daniel)
> make sure work queue is idle on suspend (Daniel)
> use a delayed work queue since there's no hurry (Daniel)
> v3: make cleanup symmetric and just call cancel work directly (Daniel)
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=54089
Use round_jiffies_up_relative(HZ) to compute the delay to align the
wakeup with others.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-02 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 22:41 [PATCH 1/4] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-31 22:41 ` [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v3 Jesse Barnes
2012-11-02 13:37 ` Chris Wilson [this message]
2012-10-31 22:41 ` [PATCH 3/4] drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex Jesse Barnes
2012-11-02 13:38 ` Chris Wilson
2012-10-31 22:41 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3 Jesse Barnes
2012-11-02 15:16 ` Chris Wilson
2012-11-02 16:40 ` Jesse Barnes
2012-11-02 13:35 ` [PATCH 1/4] drm/i915: don't block resume on fb console resume Chris Wilson
2012-11-04 21:16 ` Paul Menzel
2012-11-04 23:12 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$76je6l@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.