From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/5] drm/i915: clear up wedged transitions Date: Tue, 13 Nov 2012 08:56:39 +0000 Message-ID: References: <1352758073-31330-1-git-send-email-daniel.vetter@ffwll.ch> <1352758073-31330-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 590CB9E874 for ; Tue, 13 Nov 2012 00:56:43 -0800 (PST) In-Reply-To: <1352758073-31330-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 12 Nov 2012 23:07:52 +0100, Daniel Vetter wrote: > While auditing the code I've noticed one place (the throttle ioctl) > which does not yet wait for the reset handler to complete and doesn't > properly decode the wedge state into -EAGAIN/-EIO. Fix this up by > calling the right helpers. This might explain the oddball "my > compositor just died in a successfull gpu reset" reports. It is a standalone bugfix and should be split into its own patch. But I don't think it quite has the impact you describe, since it only called by the ddx and only sna bothers to check the error code. And one side-effect is that I think for especilly this case i915_gem_check_wedge() should be setting set_need_resched() before returning -EAGAIN. -Chris -- Chris Wilson, Intel Open Source Technology Centre