From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v2] drm/i915: Use pci_resource functions for BARs. Date: Mon, 19 Nov 2012 21:27:13 +0000 Message-ID: References: <1353355496-1067-1-git-send-email-ben@bwidawsk.net> <1353356624-15873-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C3CDE6070 for ; Mon, 19 Nov 2012 13:27:21 -0800 (PST) In-Reply-To: <1353356624-15873-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Mon, 19 Nov 2012 12:23:44 -0800, Ben Widawsky wrote: > This was leftover crap from kill-agp. The current code is theoretically > broken for 64b bars. (I resist removing theoretically because I am too > lazy to test). > > We still need to ioremap things ourselves because we want to ioremap_wc > the PTEs. > > v2: Forgot to kill the tmp variable in v1 > > CC: Chris Wilson > Signed-off-by: Ben Widawsky Nice. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre