From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: resurrect panel lid handling
Date: Tue, 20 Nov 2012 13:59:14 +0000 [thread overview]
Message-ID: <b94cdc$7ecrgt@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1353419408-30767-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 20 Nov 2012 14:50:08 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> But disabled by default. This essentially reverts
>
> commit bcd5023c961a44c7149936553b6929b2b233dd27
> Author: Dave Airlie <airlied@redhat.com>
> Date: Mon Mar 14 14:17:55 2011 +1000
>
> drm/i915: disable opregion lid detection for now
>
> but leaves the autodetect mode disabled. There's also the explicit lid
> status option added in
>
> commit fca874092597ef946b8f07031d8c31c58b212144
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Thu Feb 17 13:44:48 2011 +0000
>
> drm/i915: Add a module parameter to ignore lid status
>
> Which overloaded the meaning for the panel_ignore_lid parameter even
> more. To fix up this mess, give the non-negative numbers 0,1 the
> original meaning back and use negative numbers to force a given state.
> So now we have
>
> 1 - disable autodetect, return unknown
> 0 - enable autodetect
> -1 - force to disconnected/lid closed
> -2 - force to connected/lid open
>
> v2: My C programmer license has been revoked ...
>
> v3: Beautify the code a bit, as suggested by Chris Wilson.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=27622
> Tested-by: Andreas Sturmlechner <andreas.sturmlechner@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
One day, I would like for lid state detection to be default, but as
always the hw manufacturers conspire against us. Out of curiousity, Dave
does your HP 2540p work yet?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(You could lose the enclosing { } around the single line statement.)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-20 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 19:34 [PATCH] drm/i915: resurrect panel lid handling Daniel Vetter
2012-11-20 13:50 ` Daniel Vetter
2012-11-20 13:59 ` Chris Wilson [this message]
2012-11-20 15:33 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$7ecrgt@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.