From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Add DEBUG messages to all intel_create_user_framebuffer error paths Date: Wed, 19 Dec 2012 11:52:11 +0000 Message-ID: References: <1355868794-3708-1-git-send-email-chris@chris-wilson.co.uk> <1355868794-3708-3-git-send-email-chris@chris-wilson.co.uk> <20121219114741.GS29018@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1777086434==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E05EE5C76 for ; Wed, 19 Dec 2012 03:52:26 -0800 (PST) In-Reply-To: <20121219114741.GS29018@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1777086434== Content-Type: text/plain On Wed, 19 Dec 2012 13:47:41 +0200, Ville Syrjälä wrote: > On Tue, Dec 18, 2012 at 10:13:14PM +0000, Chris Wilson wrote: > > This proves to be very useful when investigating why code suddenly > > started failing. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/intel_display.c | 33 +++++++++++++++++++++++++-------- > > 1 file changed, 25 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index 211a097..50d6580 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -8293,19 +8293,30 @@ int intel_framebuffer_init(struct drm_device *dev, > > { > > int ret; > > > > - if (obj->tiling_mode == I915_TILING_Y) > > + if (obj->tiling_mode == I915_TILING_Y) { > > + DRM_DEBUG("hardware does not support tiling Y\n"); > > Shouldn't all of these be DRM_DEBUG_KMS()? I choose DRM_DEBUG because these are user errors, which I think has been the prevailing choice in the past. -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============1777086434== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1777086434==--