From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: disable shrinker lock stealing for create_mmap_offset Date: Wed, 19 Dec 2012 13:49:29 +0000 Message-ID: References: <453bf0$6v02iq@azsmga001.ch.intel.com> <1355924026-13159-1-git-send-email-daniel.vetter@ffwll.ch> <1355924026-13159-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id DEA16E64A4 for ; Wed, 19 Dec 2012 05:49:44 -0800 (PST) In-Reply-To: <1355924026-13159-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 19 Dec 2012 14:33:46 +0100, Daniel Vetter wrote: > The mmap offset structure is not part of the drm/i915 code, but > provided by gem helpers. To avoid leaky abstractions (by either > depending upon implementation details of said helper wrt to > preallocations, or reimplementing it in our code and so fuzzing > around in internal details of that helpr) simply disable > the shrinker lock stealing accross calls into the helper functions. > > This should fix igt/gem_tiled_swapping. Proving that if we just fixed the code stolen from us, we'd run less chance of introducing bugs.... :-p -Chris -- Chris Wilson, Intel Open Source Technology Centre