From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code
Date: Sat, 29 Dec 2012 23:44:31 +0000 [thread overview]
Message-ID: <b94cdc$7vp32s@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <20121229114509.0000701b@unknown>
On Sat, 29 Dec 2012 11:45:09 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Sat, 29 Dec 2012 11:49:01 +0000
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky <ben@bwidawsk.net>
> > wrote:
> > > This refactor clearly identifies the GEN specific portion of the
> > > aliased ppgtt code. Aside from some of the gen specific parts being
> > > extracted, it also preps us for an upcoming patch that pulls out
> > > the size, which has some nice benefits.
> >
> > Error handling looks a little wonky.
>
> I've not looked in much detail yet, but I'll assume you're right since
> I did this pretty quickly. So given that assumption, what do you think
> of the patches, useful, or waste of code complexity?
The mention of transitioning ppgtt to use objects sounds intriguing, and
without digging into the details, does seem a worthwhile design. This
series looks fine as a mean of cutting the code up into manageable
chunks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-29 23:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 4:27 [PATCH 1/5] drm/i915: trivial: kill-agp collateral cleanups Ben Widawsky
2012-12-29 4:27 ` [PATCH 2/5] drm/i915: Reclaim GTT space for failed PPGTT Ben Widawsky
2012-12-29 4:27 ` [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code Ben Widawsky
2012-12-29 11:49 ` Chris Wilson
2012-12-29 19:45 ` Ben Widawsky
2012-12-29 23:44 ` Chris Wilson [this message]
2012-12-29 4:27 ` [PATCH 4/5] drm/i915: Aliased PPGTT size abstraction Ben Widawsky
2012-12-29 4:27 ` [PATCH 5/5] drm/i915: Dynamically calculate dclv Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2013-01-26 0:41 [PATCH 0/5] [REPOST] GTT cleanups, rebased Ben Widawsky
2013-01-26 0:41 ` [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code Ben Widawsky
2013-01-29 12:55 ` Daniel Vetter
2013-01-29 19:00 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$7vp32s@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.