From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948B6C33CAA for ; Thu, 23 Jan 2020 23:06:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5987620718 for ; Thu, 23 Jan 2020 23:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UJ85+P2f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5987620718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3EB46FE98; Thu, 23 Jan 2020 23:06:10 +0000 (UTC) Received: from mail25.static.mailgun.info (mail25.static.mailgun.info [104.130.122.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F8B46FE98 for ; Thu, 23 Jan 2020 23:06:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579820769; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hgQq6Cm2C8WFWwe4zjX8Nmm79ZjwTRrTKn+plFJyrz8=; b=UJ85+P2fqnKbMEID6Do5hwwOYujm8jHarNTlPBh9ePCw6TAysi3CLj7baX7zuu24RyoBN+aj H6WQlGGkgewLohnPI9U54u+ThJfwT0dBQe9Xd4f+KEu+BhXGSTBWE5vhdNE6ir0qskDl89iO eXoK9Zuhz9B3h45OrXhEC3izpCA= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2a26dd.7f93eb5e9f80-smtp-out-n03; Thu, 23 Jan 2020 23:06:05 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 78051C4479F; Thu, 23 Jan 2020 23:06:04 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id ADB32C43383; Thu, 23 Jan 2020 23:06:03 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 23 Jan 2020 15:06:03 -0800 From: abhinavk@codeaurora.org To: =?UTF-8?Q?Ville_Syrj=C3=A4l=C3=A4?= Subject: Re: [EXT] Re: [PATCH] drm: fix HDR static metadata type field numbering In-Reply-To: <20191128111418.GP1208@intel.com> References: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> <20191127151703.GJ1208@intel.com> <20191128083940.GC10251@fsr-ub1664-121> <20191128111418.GP1208@intel.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: adelva@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Uma Shankar , seanpaul@chromium.org, dl-linux-imx , aravindh@codeaurora.org, Laurentiu Palcu Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgVmlsbGUgYW5kIExhdXJlbnRpdQoKT24gMjAxOS0xMS0yOCAwMzoxNCwgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+IE9uIFRodSwgTm92IDI4LCAyMDE5IGF0IDA4OjM5OjQxQU0gKzAwMDAsIExh dXJlbnRpdSBQYWxjdSB3cm90ZToKPj4gT24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDU6MTc6MDNQ TSArMDIwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+PiA+IENhdXRpb246IEVYVCBFbWFpbAo+ PiA+Cj4+ID4gT24gV2VkLCBOb3YgMjcsIDIwMTkgYXQgMDI6NDI6MzVQTSArMDAwMCwgTGF1cmVu dGl1IFBhbGN1IHdyb3RlOgo+PiA+ID4gQWNjb3JkaW5nIHRvIENUQS04NjEgc3BlY2lmaWNhdGlv biwgSERSIHN0YXRpYyBtZXRhZGF0YSBkYXRhIGJsb2NrIGFsbG93cyBhCj4+ID4gPiBzaW5rIHRv IGluZGljYXRlIHdoaWNoIEhEUiBtZXRhZGF0YSB0eXBlcyBpdCBzdXBwb3J0cyBieSBzZXR0aW5n IHRoZSBTTV8wIHRvCj4+ID4gPiBTTV83IGJpdHMuIEN1cnJlbnRseSwgb25seSBTdGF0aWMgTWV0 YWRhdGEgVHlwZSAxIGlzIHN1cHBvcnRlZCBhbmQgdGhpcyBpcwo+PiA+ID4gaW5kaWNhdGVkIGJ5 IHNldHRpbmcgdGhlIFNNXzAgYml0IHRvIDEuCj4+ID4gPgo+PiA+ID4gSG93ZXZlciwgdGhlIGNv bm5lY3Rvci0+aGRyX3NpbmtfbWV0YWRhdGEuaGRtaV90eXBlMS5tZXRhZGF0YV90eXBlIGlzIGFs d2F5cwo+PiA+ID4gMCwgYmVjYXVzZSBoZHJfbWV0YWRhdGFfdHlwZSgpIGluIGRybV9lZGlkLmMg Y2hlY2tzIHRoZSB3cm9uZyBiaXQuCj4+ID4gPgo+PiA+ID4gVGhpcyBwYXRjaCBjb3JyZWN0cyB0 aGUgSERNSV9TVEFUSUNfTUVUQURBVEFfVFlQRTEgYml0IHBvc2l0aW9uLgo+PiA+Cj4+ID4gV2Fz IGNvbmZ1c2VkIGZvciBhIHdoaWxlIHdoeSB0aGlzIGhhcyBldmVuIGJlZW4gd29ya25pbmcsIGJ1 dCBJIGd1ZXNzCj4+ID4gdGhhdCdzIGR1ZSB0byB1c2Vyc3BhY2UgcG9wdWxhdGluZyB0aGUgbWV0 YWRhdGEgaW5mb2ZyYW1lIGJsb2IgY29ycmVjdGx5Cj4+ID4gZXZlbiBpZiB3ZSBtaXNyZXBvcnRl ZCB0aGUgbWV0YWRhdGEgdHlwZXMgaW4gdGhlIHBhcnNlZCBFRElEIG1ldGFkYXRhCj4+ID4gYmxv Yi4KPj4gPgo+PiA+IEhtbS4gQWN0dWFsbHkgb24gZnVydGhlciBpbnNwZWN0aW9uIHRoaXMgYWxs IHNlZW1zIHRvIGJlIGRlYWQgY29kZS4gVGhlCj4+ID4gb25seSB0aGluZyB3ZSBzZWVtIHRvIHVz ZSBmcm9tIHRoZSBwYXJzZWQgRURJRCBtZXRhZGF0YSBzdHVmZiBpcwo+PiA+IGVvdGYgYml0bWFz ay4gV2UgY2hlY2sgdGhhdCBpbiBkcm1faGRtaV9pbmZvZnJhbWVfc2V0X2hkcl9tZXRhZGF0YSgp Cj4+ID4gYnV0IHdlIGRvbid0IGNoZWNrIHRoZSBtZXRhZGF0YSB0eXBlLgo+PiA+Cj4+ID4gTWF5 YmUgd2Ugc2hvdWxkIGp1c3QgbnVrZSB0aGlzIEVESUQgcGFyc2luZyBzdHVmZiBlbnRpcmVseT8g U2VlbXMKPj4gPiBwcmV0dHkgbXVjaCBwb2ludGxlc3MuCj4+IAo+PiBJJ3ZlIGJlZW4gdGhpbmtp bmcgYWJvdXQgdGhhdCBidXQgd2UgbWF5IG5lZWQgdGhlIHJlc3Qgb2YgdGhlIGZpZWxkcyAKPj4g YXMKPj4gd2VsbCwgZXZlbiB0aG91Z2ggdGhleSdyZSBub3QgY3VycmVudGx5IHVzZWQuIEknbSBy ZWZlcnJpbmcgdG8gc2luaydzCj4+IG1pbi9tYXggbHVtaW5hbmNlIGRhdGEuIFNob3VsZG4ndCB3 ZSBhbHNvIGNoZWNrIG1pbi9tYXggY2xsLCBiZXNpZGVzCj4+IGVvdGYsIHRvIG1ha2Ugc3VyZSB0 aGUgc291cmNlIGRvZXMgbm90IHBhc3MgaGlnaGVyL2xvd2VyIGx1bWluYW5jZQo+PiB2YWx1ZXMs IHRoYW4gdGhlIHNpbmsgc3VwcG9ydHMsIGZvciBvcHRpbWFsIGNvbnRlbnQgcmVuZGVyaW5nPwo+ PiAKPj4gSG93ZXZlciwgQ1RBLTg2MSBpcyBub3QgdmVyeSBjbGVhciBvbiBob3cgYSBzaW5rIHNo b3VsZCBiZWhhdmUgaWYKPj4gdGhlIENMTCB2YWx1ZXMgZXhjZWVkIHRoZSBhbGxvd2VkIHJhbmdl Li4uIDovIEFsc28sIGlmIHRoZSBDTEwgcmFuZ2UgCj4+IG9yCj4+IHRoZSBGQUxMIHZhbHVlcyBw YXNzZWQgaW4gdGhlIERSTSBpbmZvZnJhbWUgZXhjZWVkIHRoZSBzaW5rJ3MgCj4+IGFkdmVydGlz ZWQKPj4gbWluL21heCB2YWx1ZXMsIEkgZ3Vlc3MgdGhlIHNpbmsgY2Fubm90IGdvIGxvd2VyL2hp Z2hlciB0aGFuIGl0IGNhbgo+PiBhbnl3YXkuIEluIHdoaWNoIGNhc2UsIHdlIGRvbid0IHJlYWxs eSBuZWVkIHRoZSByZXN0IG9mIHRoZSBIRFIgc3RhdGljCj4+IG1ldGFkYXRhIGJsb2NrIGFuZCBu dWtpbmcgdGhhdCBwYXJ0IHNob3VsZCBiZSBvay4KPiAKPiBJJ20gdGhpbmtpbmcgd2Ugc2hvdWxk IGp1c3QgY29uY2x1ZGUgdGhhdCBzdWNoIHVzZXJzcGFjZSBpcyBhCj4gYnVnZ3kgbWVzcyBhbmQg ZGVzZXJ2ZXMgd2hhdGV2ZXIgaXQgZ2V0cy4KCltBYmhpbmF2XSBUaGUgZGlzcGxheSBkcml2ZXIg Zm9yIE1TTSBjaGlwc2V0cyByZWxpZXMgb24gdGhlIGRybV9lZGlkLmMgCnBhcnNpbmcgZm9yIHRo ZSBDRUEgZXh0ZW5zaW9uIGJsb2Nrcy4gVGhlIHBhcnRzIHdoaWNoIHVzZSB0aGlzIHNoYWxsIGJl IApwb3N0ZWQgbGF0ZXIgd2hlbiB3ZSBwb3N0IG91ciBjaGFuZ2VzIGZvciBIRFIgc3VwcG9ydCBm b3IgdGhlIGRpc3BsYXkgCmRyaXZlciBmb3IgTVNNIGNoaXBzZXQuIE1lYW53aGlsZSwgaWYgdGhl cmUgYXJlIG5vIGZ1cnRoZXIgY29uY2VybnMgb24gCnRoaXMsIHdlIHdvdWxkIGxpa2UgdG8gZ28g YWhlYWQgd2l0aCB0aGlzIGNoYW5nZSBhbmQgZ2V0IGl0IG1lcmdlZCBhcyAKaXRzIGFuIGltcG9y dGFudCBidWcgZml4LiBUaGFua3MuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33363C33CAF for ; Thu, 23 Jan 2020 23:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0171921D7E for ; Thu, 23 Jan 2020 23:06:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="N7TA0gcQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729606AbgAWXGM (ORCPT ); Thu, 23 Jan 2020 18:06:12 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:25192 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727056AbgAWXGL (ORCPT ); Thu, 23 Jan 2020 18:06:11 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579820771; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hgQq6Cm2C8WFWwe4zjX8Nmm79ZjwTRrTKn+plFJyrz8=; b=N7TA0gcQ27QJ03RE3iQuHPQFObslW+B6B9HFg4Oqlrpo2k+0ZWIWtTPoT3PYThdYvmi5hBeD 2wu6/QlurXm1Mfmyw0iRlmtiyUX0C+V5NFYZtEvEZ9SuTfv94ucNy6bGPhFL2DadVVOQ/HoE HG2qCyQFM68J8PF5SFxfPn+Rl1A= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2a26de.7f30f685b110-smtp-out-n01; Thu, 23 Jan 2020 23:06:06 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7FAF5C447A3; Thu, 23 Jan 2020 23:06:04 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id ADB32C43383; Thu, 23 Jan 2020 23:06:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 23 Jan 2020 15:06:03 -0800 From: abhinavk@codeaurora.org To: =?UTF-8?Q?Ville_Syrj=C3=A4l=C3=A4?= Cc: Laurentiu Palcu , Daniel Vetter , Uma Shankar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dl-linux-imx , nganji@codeaurora.org, aravindh@codeaurora.org, adelva@google.com, seanpaul@chromium.org, jsanka@codeaurora.org Subject: Re: [EXT] Re: [PATCH] drm: fix HDR static metadata type field numbering In-Reply-To: <20191128111418.GP1208@intel.com> References: <1574865719-24490-1-git-send-email-laurentiu.palcu@nxp.com> <20191127151703.GJ1208@intel.com> <20191128083940.GC10251@fsr-ub1664-121> <20191128111418.GP1208@intel.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ville and Laurentiu On 2019-11-28 03:14, Ville Syrjälä wrote: > On Thu, Nov 28, 2019 at 08:39:41AM +0000, Laurentiu Palcu wrote: >> On Wed, Nov 27, 2019 at 05:17:03PM +0200, Ville Syrjälä wrote: >> > Caution: EXT Email >> > >> > On Wed, Nov 27, 2019 at 02:42:35PM +0000, Laurentiu Palcu wrote: >> > > According to CTA-861 specification, HDR static metadata data block allows a >> > > sink to indicate which HDR metadata types it supports by setting the SM_0 to >> > > SM_7 bits. Currently, only Static Metadata Type 1 is supported and this is >> > > indicated by setting the SM_0 bit to 1. >> > > >> > > However, the connector->hdr_sink_metadata.hdmi_type1.metadata_type is always >> > > 0, because hdr_metadata_type() in drm_edid.c checks the wrong bit. >> > > >> > > This patch corrects the HDMI_STATIC_METADATA_TYPE1 bit position. >> > >> > Was confused for a while why this has even been workning, but I guess >> > that's due to userspace populating the metadata infoframe blob correctly >> > even if we misreported the metadata types in the parsed EDID metadata >> > blob. >> > >> > Hmm. Actually on further inspection this all seems to be dead code. The >> > only thing we seem to use from the parsed EDID metadata stuff is >> > eotf bitmask. We check that in drm_hdmi_infoframe_set_hdr_metadata() >> > but we don't check the metadata type. >> > >> > Maybe we should just nuke this EDID parsing stuff entirely? Seems >> > pretty much pointless. >> >> I've been thinking about that but we may need the rest of the fields >> as >> well, even though they're not currently used. I'm referring to sink's >> min/max luminance data. Shouldn't we also check min/max cll, besides >> eotf, to make sure the source does not pass higher/lower luminance >> values, than the sink supports, for optimal content rendering? >> >> However, CTA-861 is not very clear on how a sink should behave if >> the CLL values exceed the allowed range... :/ Also, if the CLL range >> or >> the FALL values passed in the DRM infoframe exceed the sink's >> advertised >> min/max values, I guess the sink cannot go lower/higher than it can >> anyway. In which case, we don't really need the rest of the HDR static >> metadata block and nuking that part should be ok. > > I'm thinking we should just conclude that such userspace is a > buggy mess and deserves whatever it gets. [Abhinav] The display driver for MSM chipsets relies on the drm_edid.c parsing for the CEA extension blocks. The parts which use this shall be posted later when we post our changes for HDR support for the display driver for MSM chipset. Meanwhile, if there are no further concerns on this, we would like to go ahead with this change and get it merged as its an important bug fix. Thanks.