Re: [PATCH 2/4] drm/amdgpu: Clarify that BO size is in bytes in comments

["Christian König" <christian.koenig@amd.com>]

On 01.09.25 12:00, Timur Kristóf wrote:
> To avoid confusion with dwords.
> 
> Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 122a88294883..9ffadc029ef8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -220,7 +220,7 @@ void amdgpu_bo_placement_from_domain(struct amdgpu_bo *abo, u32 domain)
>   * amdgpu_bo_create_reserved - create reserved BO for kernel use
>   *
>   * @adev: amdgpu device object
> - * @size: size for the new BO
> + * @size: size for the new BO in bytes

That is actually incorrect. The size is in arbitrary units.

For OA and GWS it is the number of HW engines they represent, for GDS it is in bytes and for VRAM and GTT it is in bytes but rounded up to a page size.

Regards,
Christian.

>   * @align: alignment for the new BO
>   * @domain: where to place it
>   * @bo_ptr: used to initialize BOs in structures
> @@ -317,7 +317,7 @@ int amdgpu_bo_create_reserved(struct amdgpu_device *adev,
>   * amdgpu_bo_create_kernel - create BO for kernel use
>   *
>   * @adev: amdgpu device object
> - * @size: size for the new BO
> + * @size: size for the new BO in bytes
>   * @align: alignment for the new BO
>   * @domain: where to place it
>   * @bo_ptr:  used to initialize BOs in structures