From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rupjyoti Sarmah <rsarmah@apm.com>
Date: Wed, 7 Jul 2010 15:48:13 +0530
Subject: [U-Boot] [PATCH v1]ppc4xx/Canyonlands added USB board callbacks
In-Reply-To: <20100707073138.806C3160691@gemini.denx.de>
References: <201007070632.o676WvS8029128@amcc.com>
	<20100707073138.806C3160691@gemini.denx.de>
Message-ID: <b9c9fd0f573476e59f0b66a73c36f80a@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

Sent: Wednesday, July 07, 2010 1:02 PM
To: Rupjyoti Sarmah
> -		if (in_8((void *)(CONFIG_SYS_BCSR_BASE + 3)) &
CONFIG_SYS_BCSR3_PCIE)
> +		if (bcsr_data->board_status & CONFIG_SYS_BCSR3_PCIE)

Please use I/O accessors to read the BCSR.

> -	printf(", Rev. %X", in_8((void *)(CONFIG_SYS_BCSR_BASE + 0)));
> +	printf(", Rev. %X", bcsr_data->cpld_rev);

Ditto. There are more changes like this - please fix all of them.

>>> Done.

> --- a/include/configs/canyonlands.h
> +++ b/include/configs/canyonlands.h

What is "ep460c"? We know 460EX (the CPU) and Canyonlands (the board).

>>> It is the Canyonlands board user manual ( ep460c from embedded
planet).
I changed this comment to make it more clear.

I am submitting [PATCH v2] with the changes.

Regards,
Rup