From: Dan Carpenter <error27@gmail.com>
To: Sumitra Sharma <sumitraartsy@gmail.com>
Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: pi433: Change bit_rate type from u16 to u32
Date: Sat, 11 Mar 2023 15:39:28 +0300 [thread overview]
Message-ID: <b9d62635-b968-4dfd-aa10-e34e38a114a5@kili.mountain> (raw)
In-Reply-To: <20230311122346.GA21752@ubuntu>
On Sat, Mar 11, 2023 at 04:23:46AM -0800, Sumitra Sharma wrote:
> Change bit_rate type from u16 to u32 inside struct pi433_tx_cfg to
> support bit rates up to 300kbps as per the spec.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
That's not right. Read this for more information:
https://lore.kernel.org/all/?q=pi433_tx_cfg%20bit_rate
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-11 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 12:23 [PATCH] Staging: pi433: Change bit_rate type from u16 to u32 Sumitra Sharma
2023-03-11 12:31 ` Greg KH
2023-03-11 12:39 ` Dan Carpenter [this message]
2023-03-11 13:00 ` Sumitra Sharma
2023-03-11 13:17 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-03-11 11:42 Sumitra Sharma
2023-03-11 11:50 ` Julia Lawall
2023-03-11 11:59 ` Sumitra Sharma
2023-03-11 12:12 ` Julia Lawall
2023-03-13 1:34 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d62635-b968-4dfd-aa10-e34e38a114a5@kili.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.