From: Helge Deller <deller@gmx.de>
To: Carlos O'Donell <carlos@systemhalted.org>
Cc: John David Anglin <dave.anglin@bell.net>,
Jeff Law <law@redhat.com>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>
Subject: Re: Change call ABI on PA-RISC
Date: Tue, 15 Nov 2016 19:30:25 +0100 [thread overview]
Message-ID: <b9d85ee3-6509-9648-feee-21ebf9d50b2b@gmx.de> (raw)
In-Reply-To: <CAE2sS1g2AX328mz+vi0sfGEuS=YX0=aoOCFg+evfB9-5TJ-Cjg@mail.gmail.com>
Hi Carlos,
On 14.11.2016 18:23, Carlos O'Donell wrote:
> On Mon, Nov 14, 2016 at 11:24 AM, Helge Deller <deller@gmx.de> wrote:
>> What I want to archieve is to modify the return pointer, in order
>> to be able to track when the function returns to his caller.
>> The kernel ftracer uses this then to generate call stacks and to
>> time the function.
>> Looking at the above code, it should then be possible for me
>> to modify -10(r3), but is there a guarantee that it's always at
>> -10(r3) and that r3 is used?
>> That's the reason I asked if we could modify mcount to
>> give the address (in the stack) of the return pointer, but maybe
>> it's just overkill for this use case ?
>
> Why do you need to modify the value?
>
> AFAICT ftrace uses these values heuristically e.g.
> HAVE_FUNCTION_GRAPH_FP_TEST, HAVE_FUNCTION_GRAPH_RET_ADDR_PTR?
>
> For example the only uses I see are in ftrace_pop_return_trace() and
> they are purely heuristic.
Maybe I get you wrong, but do you suggest I don't need to implement
it because it's just heuristic ?
(I agree, it's not top priority, but nice to have nevertheless)
Helge
next prev parent reply other threads:[~2016-11-15 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 18:00 Change call ABI on PA-RISC John David Anglin
2016-11-13 18:37 ` Helge Deller
2016-11-13 18:56 ` Jeff Law
2016-11-13 19:48 ` Helge Deller
2016-11-14 8:21 ` Jeff Law
2016-11-14 15:11 ` John David Anglin
2016-11-14 16:24 ` Helge Deller
2016-11-14 17:02 ` John David Anglin
2016-11-14 17:02 ` Jeff Law
2016-11-14 17:23 ` Carlos O'Donell
2016-11-15 18:30 ` Helge Deller [this message]
2016-11-16 0:04 ` John David Anglin
2016-11-17 20:19 ` Carlos O'Donell
2016-11-14 13:32 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d85ee3-6509-9648-feee-21ebf9d50b2b@gmx.de \
--to=deller@gmx.de \
--cc=carlos@systemhalted.org \
--cc=dave.anglin@bell.net \
--cc=law@redhat.com \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.