From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c [v4] Date: Thu, 21 Oct 2010 10:36:33 +0100 Message-ID: References: <20100924194432.22789.62847.stgit@localhost.localdomain> <20101020194541.GC15994@hardeman.nu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0629143048==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E4989E76B for ; Thu, 21 Oct 2010 02:36:39 -0700 (PDT) In-Reply-To: <20101020194541.GC15994@hardeman.nu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: jesse.barnes@intel.com List-Id: intel-gfx@lists.freedesktop.org --===============0629143048== Content-Type: text/plain On Wed, 20 Oct 2010 21:45:41 +0200, David Härdeman wrote: > On Fri, Sep 24, 2010 at 09:44:32PM +0200, David Härdeman wrote: > > Two questions still remain: > > > > I'm assuming that the sdvo hardware also stores a header ECC byte in > > the MSB of the first dword - is this correct? > > > > Does the SDVOB and SDVOC handling in intel_hdmi_set_avi_infoframe() > > look correct? > > Ping... Sorry David, I thought I had replied but it never made it to the list. I was half waiting if someone would find the answer to your questions. I am not certain about the reg -> port conversion either, but if it works for you, that is a major step forward. More importantly, the patch is missing your signed-off-by, which states that the work is yours (or at least you vouchsafe for the originality of the work) and you are free to contribute this work to upstream. Just reply adding your 'Signed-off-by' and I'll push the patch to -next. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============0629143048== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0629143048==--