From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v2] drm/i915: set scanout buffer as uncached
	on Sandybridge
Date: Thu, 28 Oct 2010 10:09:18 +0100
Message-ID: <b9dded$gtprb6@orsmga002.jf.intel.com>
References: <1288246569-5720-1-git-send-email-zhenyuw@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0C2129E92A
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 28 Oct 2010 02:09:40 -0700 (PDT)
In-Reply-To: <1288246569-5720-1-git-send-email-zhenyuw@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Zhenyu Wang <zhenyuw@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 28 Oct 2010 14:16:09 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> +	ret = i915_gem_object_enable_scanout(obj);
> +	if (ret) {
> +		kfree(intel_fb);
> +		return ERR_PTR(ret);
> +	}

We need to introduce a mutex_lock here. I wonder whether it is truly worth
it. Yes, user space often creates a fb for a new obj so we avoid the
unbind penalty on flipping to this fb. But that first rebind is a one-off
event as well, and we probably should look at how we can simply change
caching bits in the PTE on the fly.

In the short term I'll drop this hunk. I've pushed this to -staging as I'd
like to get another tested-by or reviewed-by and then send it to stable.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre