From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 0/2] drm/i915: enable CxSR and FBC on Sandybridge Date: Wed, 15 Dec 2010 10:32:50 +0000 Message-ID: References: <1292398952-11378-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EF269EEA3 for ; Wed, 15 Dec 2010 02:33:10 -0800 (PST) In-Reply-To: <1292398952-11378-1-git-send-email-yuanhan.liu@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Yuanhan Liu , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 15 Dec 2010 15:42:30 +0800, Yuanhan Liu wrote: > Hi, > > This two patches enable self refresh and frame buffer compression > on Sandybridge. > > FYI, with my test, enable CxSR would save about 0.7W, while enable > FBC would save about 0.1~0.2W. Do you have some numbers comparable to https://bugs.freedesktop.org/show_bug.cgi?id=31588 ? I'm interested to know if, first, we are able to reproduce those numbers and, secondly, if we've started to narrow the 3W gap for enabling a pipe between the Windows driver and ourselves. The patches themselves look good. A minor bit of code duplication that we could possibly eliminate in the first... -Chris -- Chris Wilson, Intel Open Source Technology Centre