Re: [PATCH] i915: Modify for pineview clock source

[Chris Wilson <chris@chris-wilson.co.uk>]

On Tue, 14 Dec 2010 11:40:30 -0800, bfreed@chromium.org wrote:
> The i915 driver normally assumes the video bios has configured several 
> of the LVDS panel registers, and it just inherits the values. If the 
> vbios has not run, several of these will need to be setup. 

I'm having problems applying these using git-am. Notably your base objects
are not in my tree.

I'm dubious about flipping the SSC bit just for PineView. On recent
platforms, I think using an SSC reference is prevalent.

Instead of hardcoding 100Mhz as the clock, I'd prefer to see those SSC
frequencies split out of the general definitions and shared with this
initialiser. Something like:
int intel_bios_ssc_frequency(struct drm_device *dev, bool high_speed)
{
   switch(INTEL_INFO(dev)->gen) {
   case 2: return high_speed ? 66 : 48;
   case 3:
   case 4: return high_speed ? 100 : 96;
   default: return high_speed ? 120 : 100;
   }
}
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre