From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm: dumb scanout create/mmap for intel/radeon (v3) Date: Fri, 07 Jan 2011 00:12:15 +0000 Message-ID: References: <1294355811-3225-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 7347E9E947 for ; Thu, 6 Jan 2011 16:12:18 -0800 (PST) In-Reply-To: <1294355811-3225-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, 7 Jan 2011 09:16:51 +1000, Dave Airlie wrote: > +int > +i915_gem_dumb_create(struct drm_file *file, > + struct drm_device *dev, > + struct drm_mode_create_dumb *args) > +{ > + /* have to work out size/pitch and return them */ > + args->pitch = ALIGN(args->width & ((args->bpp + 1) / 8), 64); ^ oops I think you meant args->width * ((args->bpp + 7) /8) > + args->size = args->pitch * args->height; > + return i915_gem_create(file, dev, > + args->size, &args->handle); > +} The only issue with the dumb libkms fb is the transition to X. Is the nature of the dumb fb such that we would be prohibited from blitting to the X fb, or can we use platform specific knowledge to know how we can abuse it? -Chris -- Chris Wilson, Intel Open Source Technology Centre