From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/8] drm/i915: skip redundant operations whilst enabling pipes and planes Date: Fri, 18 Mar 2011 17:37:06 +0000 Message-ID: References: <1300435330-15934-1-git-send-email-chris@chris-wilson.co.uk> <1300435330-15934-3-git-send-email-chris@chris-wilson.co.uk> <20110318092522.72958a12@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DE2C9E77A for ; Fri, 18 Mar 2011 10:37:10 -0700 (PDT) In-Reply-To: <20110318092522.72958a12@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 18 Mar 2011 09:25:22 -0700, Jesse Barnes wrote: > On Fri, 18 Mar 2011 08:02:04 +0000 > Chris Wilson wrote: > > > If the pipe or plane is already enabled, then we do not need to enable > > it again and can skip the delay. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=34601 > > Cc: Jesse Barnes > > Signed-off-by: Chris Wilson > > --- > > Does this one actually fix the issue? Unless we're trying to get > suspend, resume, or mode setting down under 100ms it's probably not > worth it to try to avoid the vblank waits (this is me being paranoid > about our mode setting code). This is the one QA identified as fixing the regression from b24e717988, which worries me. I admit to not knowing what the root cause is, but it was a change introduced by b24e71798 and had unfortunate side-effects. -Chris -- Chris Wilson, Intel Open Source Technology Centre