From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] i915: restore only the mode of this driver on lastclose Date: Mon, 11 Apr 2011 08:21:02 +0100 Message-ID: References: <1302499397-11051-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 648D49E765 for ; Mon, 11 Apr 2011 00:21:05 -0700 (PDT) In-Reply-To: <1302499397-11051-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, 11 Apr 2011 15:23:17 +1000, Dave Airlie wrote: > From: Dave Airlie > > This has always used a big hammer, but that hammer is probably > too big, I'm also not sure its necessary but at least this > should be safe. So the difference appears to be that the patch only restores the fbcon of a device for the lastclose of that device. That makes sense. However, would it not be better to make this a generic drm_fb_helper_restore_mode() as it sounds like something every driver should consider? -Chris -- Chris Wilson, Intel Open Source Technology Centre