From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: restore only the mode of this driver on lastclose (v2) Date: Wed, 13 Apr 2011 08:00:33 +0100 Message-ID: References: <1302651355-15905-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 82D2B9E748 for ; Wed, 13 Apr 2011 00:00:36 -0700 (PDT) In-Reply-To: <1302651355-15905-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 13 Apr 2011 09:35:55 +1000, Dave Airlie wrote: > From: Dave Airlie > > i915 calls the panic handler function on last close to reset the modes, > however this is a really bad idea for multi-gpu machines, esp shareable > gpus machines. So add a new entry point for the driver to just restore > its own fbcon mode. > > v2: move code into fb helper, fix panic code to block mode change on > powered off GPUs. 2 bugs in one patch? This could be split into 3 steps... ;-) Aside from that, looks good. -Chris -- Chris Wilson, Intel Open Source Technology Centre