From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-s390x@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write() logic into probe_access()
Date: Wed, 28 Aug 2019 07:52:57 -0700 [thread overview]
Message-ID: <b9eb6e23-bcde-e987-048a-e174070d975c@linaro.org> (raw)
In-Reply-To: <20190828111004.28013-3-david@redhat.com>
On 8/28/19 4:10 AM, David Hildenbrand wrote:
> +void *probe_access(CPUArchState *env, target_ulong addr, int size,
> + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
> {
> CPUState *cpu = env_cpu(env);
> CPUClass *cc;
> + int flags;
>
> g_assert(-(addr | TARGET_PAGE_MASK) >= size);
> + g_assert(mmu_idx == MMU_USER_IDX);
We ignore mmu_idx pretty much everywhere else.
Why bother now?
r~
next prev parent reply other threads:[~2019-08-28 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 11:10 [Qemu-devel] [PATCH v1 0/2] tcg: Introduce probe_access() and return a host pointer David Hildenbrand
2019-08-28 11:10 ` [Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page David Hildenbrand
2019-08-28 14:44 ` Richard Henderson
2019-08-28 20:34 ` David Hildenbrand
2019-08-28 11:10 ` [Qemu-devel] [PATCH v1 2/2] tcg: Factor out probe_write() logic into probe_access() David Hildenbrand
2019-08-28 14:52 ` Richard Henderson [this message]
2019-08-28 20:30 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9eb6e23-bcde-e987-048a-e174070d975c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.