From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Zhang Yi <zhangyi@everest-semi.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
devicetree@vger.kernel.org
Cc: tiwai@suse.com
Subject: Re: [PATCH v1 1/2] ASoC: codecs: add support for ES8389
Date: Mon, 3 Mar 2025 10:03:47 +0100 [thread overview]
Message-ID: <b9f54209-0690-46ba-a08f-d6bacad6cf2d@linux.intel.com> (raw)
In-Reply-To: <20250228100245.127413-2-zhangyi@everest-semi.com>
On 2/28/2025 11:02 AM, Zhang Yi wrote:
> + /* clock inversion */
> + switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> + case SND_SOC_DAIFMT_NB_NF:
> + break;
> + case SND_SOC_DAIFMT_IB_IF:
> + break;
> + case SND_SOC_DAIFMT_IB_NF:
> + break;
> + case SND_SOC_DAIFMT_NB_IF:
> + break;
> + default:
> + break;
> + }
This switch does nothing. Remove it?
next prev parent reply other threads:[~2025-03-03 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 10:02 [PATCH v1 0/2] ASoC: codecs: add ES8389 codec driver Zhang Yi
2025-02-28 10:02 ` [PATCH v1 1/2] ASoC: codecs: add support for ES8389 Zhang Yi
2025-03-03 9:03 ` Amadeusz Sławiński [this message]
2025-02-28 10:02 ` [PATCH v1 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC Zhang Yi
2025-02-28 11:28 ` Rob Herring (Arm)
2025-02-28 12:46 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2025-03-03 9:20 [PATCH v1 1/2] ASoC: codecs: add support for ES8389 Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f54209-0690-46ba-a08f-d6bacad6cf2d@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.