From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E811C433DF for ; Tue, 21 Jul 2020 13:32:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07ACA21702 for ; Tue, 21 Jul 2020 13:32:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iZ1lQbX8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R2MkfsCQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07ACA21702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 75E9414E; Tue, 21 Jul 2020 15:31:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 75E9414E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595338365; bh=Pt+GzWkxP1A5ATQGkWe9PChiAPBJRw+/ivN92QlY3LM=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iZ1lQbX83LGXDLX7XhGrER/5z1qfC9wBBL910sK2YiSevy+uOeCXAqqN8NDoHtt9r rtaueiXnO+ItzrR4uJz3rGNPCPZtCIKqy8X7Ht277tkYBWU7E1hTK4SRpjgJYMsSzW Tyay7dL6Y5Yv0xsvFIWVMj0L4t50h679Opel2wxw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5DCAF80087; Tue, 21 Jul 2020 15:31:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B8DEF8024A; Tue, 21 Jul 2020 15:31:52 +0200 (CEST) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9F2C2F80117 for ; Tue, 21 Jul 2020 15:31:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9F2C2F80117 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R2MkfsCQ" Received: by mail-wm1-x343.google.com with SMTP id c80so2862449wme.0 for ; Tue, 21 Jul 2020 06:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uyBU0n93mYL4MPnVZSrUf3hQRNa7z/RTZ/TKuAjq3Q8=; b=R2MkfsCQuYWzdV3pwRrLaT8N1kzRpNcsFvr6wnqUiJrQk9jaPTpAwG9/BxmKH0fg4e csnBNsmMOvVrz/CJ+WpUAIOUa92I9kRfRCKd33NJX/RQ5DALtKWGB9IV/8y5YuU/FEGm ABQSVM09Kd1gfUDLlBqWcP6KdrcFWArxsSp6AkHFMYr/bnYPxQntffyf8B9orCvGnSZD kpIz2FAvQ6MLmX+RfADxPxmtyzNZ4rFR5tmSwBCK0I9/l1n0ZDpLwFbwZ9tSpvPX0XTL LQHQMEMxDFZ0U2xD6mGRCERCgYTrwUvl8rhc9PPSgVVavx2jLMlCN/QIytxMBrCHlFab 81Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uyBU0n93mYL4MPnVZSrUf3hQRNa7z/RTZ/TKuAjq3Q8=; b=stEW3Q0GaRj8OY8pn8RXhngk9sCp+4ZEkO0+W07x2dPfKdULiFoQ/QPOl5Q+T8NSYO j7A8q0h6XJdIKsKU/DL+WTDUEsEIzkK6NvFINQAXhrVQnVbtay7qnQR38zkNhv/Plqlc Pvm4zka0RRe2+BYVYW8DYPT8iIN6B6QsrappYBiOFvTgohPigMMaeg7WoL0iB7BCbu+G BTMI9RCBGN7CxXKJGgKoKzUMu8GlzcBi160DCpf/rC0SVd1cadw1NcBbxZn1xzRWdMVc mBavVI3wP8mgNHFXvyJMW84ePc0pwKxKh3JwtDRu08c5VYPgC/wXGwMKD8v5M1MCxfpX 67hg== X-Gm-Message-State: AOAM533tGWtjOKLioVotvMaB61uYo71IJ+fEnmbs5wB4AQja+W/sqrTq rZFbVZA3o3U1vXBvGpoFzOU= X-Google-Smtp-Source: ABdhPJzuacQT/Evp2PHZb0CQXYblt0HAY+Bj+IAqC14Rd4DQUDuO+4iTsHjhrA3NqW8RBRIhAaQjlw== X-Received: by 2002:a1c:5453:: with SMTP id p19mr3983422wmi.41.1595338296463; Tue, 21 Jul 2020 06:31:36 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.9]) by smtp.gmail.com with ESMTPSA id j8sm21924758wrd.85.2020.07.21.06.31.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2020 06:31:35 -0700 (PDT) Subject: Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7 To: Tzung-Bi Shih References: <846feea6-e2b6-3a0e-b05f-d70e898f9ea5@gmail.com> From: Alper Nebi Yasak Message-ID: Date: Tue, 21 Jul 2020 16:31:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ALSA development , Heiko Stuebner , Linux Kernel Mailing List , Takashi Iwai , Liam Girdwood , linux-rockchip@lists.infradead.org, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 21/07/2020 14:46, Tzung-Bi Shih wrote: > Hi, I got a rk3399-gru-kevin and can reproduce the issue. > > Could you take a try on the proposed patch here > https://patchwork.kernel.org/patch/11675533/ to see if it fixes? It does eliminate the pops, thanks. (I've replied to the patch, I am sending this for completeness as the Cc list isn't exactly the same.) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alper Nebi Yasak Subject: Re: Speaker pops with max98357a on rk3399-gru-kevin since v5.7 Date: Tue, 21 Jul 2020 16:31:31 +0300 Message-ID: References: <846feea6-e2b6-3a0e-b05f-d70e898f9ea5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tzung-Bi Shih Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , ALSA development , Linux Kernel Mailing List , linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On 21/07/2020 14:46, Tzung-Bi Shih wrote: > Hi, I got a rk3399-gru-kevin and can reproduce the issue. > > Could you take a try on the proposed patch here > https://patchwork.kernel.org/patch/11675533/ to see if it fixes? It does eliminate the pops, thanks. (I've replied to the patch, I am sending this for completeness as the Cc list isn't exactly the same.)