From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA2F1A2C0B for ; Tue, 10 Dec 2024 14:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733841046; cv=none; b=Lnu/ObONZ/1R1BQ4bjp6PEfPtUhfGPjbbVdZ3Fjym0/sSftiuJDKUhG+OvZ/Obj9B/G38VukVIqm5qWBI2Z4YfdXYoAx4gfUJVzwNpXolCX+jgiVwf/RK1U/h50a4iaUzUC5VI7OCGLDXEceJUMuQuhhTUz2wfcRoModj76zMB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733841046; c=relaxed/simple; bh=TNR+svsYtSGBCD44qpcEC0roW05ZrgERrxUBDJIlMsU=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=kkEaIq99ipshGg+/eZlfjuKAJ8shGW+aqz+I9EnpDL3bFQM2bftj1cpcc0YpERmWcBBIOkTye81DkLj4fa/SrPqxZSZkoYaUYnR1P52GRUOZT4os0No5jjNVrVaFXLSWHe3lttVO21aLJQe+C4N7SdrMkheVgFVs/MlHPG9hh+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=p4P9u5cg; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=TDKABZQd; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="p4P9u5cg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TDKABZQd" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 693E913841C4; Tue, 10 Dec 2024 09:30:42 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Tue, 10 Dec 2024 09:30:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733841042; x=1733927442; bh=Uil3wJvR16+q+H5kSH9NNdVYOiOEWY9WIj6bzx8DuI0=; b= p4P9u5cgzQZrXc94sjttH74v5r8YoxKe8PwgblnL3AuFJJKVeSNQcEJ+0dx5JQ2x iVkB4eqIcftU/iQjmXAkflxzecpIKZYY7uhn/x3mN3edPFatfhgnVZBF/hEoh10B /jO/tWYXI21ycUC1jufuyVk2xhsVNHF8j3W1OTNrb31o0sNf2rcCOYKungRoLY74 j6/YcAm1S8apWi7dJlgMYmqk1E/skBGyg6oOaPRDb0b4BhIHAkciWCRUrJoZAlWd QU7Oe2eNy+O28PINbv5+fFMX5ORX+FeOZr0xp1/GE2uac/ccNuvNwWA4nsky1waL AQO4+UhzSPxX3lR610W9sg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733841042; x= 1733927442; bh=Uil3wJvR16+q+H5kSH9NNdVYOiOEWY9WIj6bzx8DuI0=; b=T DKABZQd2TG6QBYP2NR+EGNebEjZC4X7gTe6Jjgvcw7vAU1VAUHhsRwSbPuq19jHT p9ZvtBuTbZZWuDPPJJCxALqfM6d2re8ddu6JI1SnfvKMbdyVCwrqj9Jc5A2wq5je P4q6zDuzdWs/M5zqpQcTnTeAYjteVWuFVAOwNJw4DUULueTuvkIukCsgbOq2nbOg Xr3+QoLvOo93tTj71N6FVXfU9qMJl/E/eImUPYBR1J1Fa6MeEo+V76Zk1YFuAPER Gw1CZNes12jmlk/QGZfdqPKGCh4iKcQL+PzTx2XvVstc5Urc+ReOjOTEXhg2Ga61 lfd3Pz1379j4ZlSRsnZew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeekgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredttden ucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdrug gvqeenucggtffrrghtthgvrhhnpeefhfehteffuddvgfeigefhjeetvdekteekjeefkeek leffjeetvedvgefhhfeihfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhn uggsrdguvgdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepshhimhhonhgrsehffhiflhhlrdgthhdprhgtphhtthhopegrihhrlhhivggusehg mhgrihhlrdgtohhmpdhrtghpthhtohepuggvlhhlvghrsehgmhigrdguvgdprhgtphhtth hopegurhhiqdguvghvvghlsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhr tghpthhtoheplhhinhhugidqshhtrghgihhngheslhhishhtshdrlhhinhhugidruggvvh dprhgtphhtthhopehlihhnuhigphhptgdquggvvheslhhishhtshdrohiilhgrsghsrdho rhhgpdhrtghpthhtohepjhgrvhhivghrmhesrhgvughhrghtrdgtohhmpdhrtghpthhtoh epthiiihhmmhgvrhhmrghnnhesshhushgvrdguvgdprhgtphhtthhopehlihhnuhigqdhf sgguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C01EC2220072; Tue, 10 Dec 2024 09:30:41 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 10 Dec 2024 15:30:20 +0100 From: "Arnd Bergmann" To: "Thomas Zimmermann" , "Javier Martinez Canillas" , "Helge Deller" , "Simona Vetter" , "Dave Airlie" Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Message-Id: In-Reply-To: <20241210142329.660801-2-tzimmermann@suse.de> References: <20241210142329.660801-1-tzimmermann@suse.de> <20241210142329.660801-2-tzimmermann@suse.de> Subject: Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Dec 10, 2024, at 15:09, Thomas Zimmermann wrote: > Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter > only controls backlight support within fbdev core code and data > structures. > > Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users > select it explicitly. Fixes warnings about recursive dependencies, > such as > > error: recursive dependency detected! > symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT > symbol FB_BACKLIGHT is selected by FB_SH_MOBILE_LCDC > symbol FB_SH_MOBILE_LCDC depends on FB_DEVICE > symbol FB_DEVICE depends on FB_CORE > symbol FB_CORE is selected by DRM_GEM_DMA_HELPER > symbol DRM_GEM_DMA_HELPER is selected by DRM_PANEL_ILITEK_ILI9341 > symbol DRM_PANEL_ILITEK_ILI9341 depends on BACKLIGHT_CLASS_DEVICE > > BACKLIGHT_CLASS_DEVICE is user-selectable, so making drivers adapt to > it is the correct approach in any case. For most drivers, backlight > support is also configurable separately. > > Signed-off-by: Thomas Zimmermann Thanks for revisiting this! My patch that failed to work correctly happened to work on my randconfig tree because I still have an old variant of this change, see https://lore.kernel.org/linux-fbdev/20200417155553.675905-8-arnd@arndb.de/ This is almost the same as your version, except for the optional fbdev Kconfig bits PERS > @@ -660,7 +661,6 @@ config FB_ATMEL > config FB_NVIDIA > tristate "nVidia Framebuffer Support" > depends on FB && PCI > - select FB_BACKLIGHT if FB_NVIDIA_BACKLIGHT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -700,6 +700,8 @@ config FB_NVIDIA_DEBUG > config FB_NVIDIA_BACKLIGHT > bool "Support for backlight control" > depends on FB_NVIDIA > + depends on BACKLIGHT_CLASS_DEVICE > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. For instance here I used @@ -702,6 +703,7 @@ config FB_NVIDIA_DEBUG config FB_NVIDIA_BACKLIGHT bool "Support for backlight control" depends on FB_NVIDIA + depends on BACKLIGHT_CLASS_DEVICE=y || BACKLIGHT_CLASS_DEVICE=FB_NVIDIA default y help Say Y here if you want to control the backlight of your display. while your patch causes a link failure with CONFIG_FB_NVIDIA=y CONFIG_FB_NVIDIA_BACKLIGHT=y CONFIG_BACKLIGHT_CLASS_DEVICE=m Arnd