From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
"Zulkifli,
Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
Cc: "intel-wired-lan@osuosl.org" <intel-wired-lan@osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1] igc: Add transmission overrun counter
Date: Tue, 21 Feb 2023 15:11:55 -0800 [thread overview]
Message-ID: <ba4f9ac9-e8f5-3930-ef76-c51bcecfaf36@intel.com> (raw)
In-Reply-To: <20230220142017.1c0b57be@kernel.org>
On 2/20/2023 2:20 PM, Jakub Kicinski wrote:
> On Sat, 18 Feb 2023 06:19:31 +0000 Zulkifli, Muhammad Husaini wrote:
>> Hi Jakub and Vinicius,
>>
>> I would appreciate any early feedback or thoughts on this patch submission.
>>
>> History of the discussion:
>> https://lore.kernel.org/intel-wired-lan/SJ1PR11MB6180D0D59EB01AD1E8FE4991B8A39@SJ1PR11MB6180.namprd11.prod.outlook.com/T/#r8db595a7b40067d2315def91d41c9695454d6c9f
>
> Tony asks very good questions. Driver specific counter always reported
> as 0 would be odd for Linux. The counter is of no practical importance.
Maybe too obvious a question, but it looks like your patch, Muhammad,
forgot to add the code that increments the counter?
If you add that, then the patch makes sense.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-02-21 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 4:45 [Intel-wired-lan] [PATCH net-next v1] igc: Add transmission overrun counter Muhammad Husaini Zulkifli
2023-02-15 19:23 ` Tony Nguyen
2023-02-15 23:40 ` Zulkifli, Muhammad Husaini
2023-02-18 6:19 ` Zulkifli, Muhammad Husaini
2023-02-20 22:20 ` Jakub Kicinski
2023-02-21 23:11 ` Jesse Brandeburg [this message]
2023-02-21 23:57 ` Jesse Brandeburg
2023-03-31 1:23 ` Zulkifli, Muhammad Husaini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba4f9ac9-e8f5-3930-ef76-c51bcecfaf36@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=kuba@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.