Re: issues to bring up two VSC8531 PHYs

[Heiner Kallweit <hkallweit1@gmail.com>]

On 13.04.2023 00:20, Andrew Lunn wrote:
>>> Also, I hooked up a logic analyzer to the mdio lines and can see communications happening at boot time. Also, it appears that it's able to read the link status correctly (when a cable is plugged):
>>> # mdio 11c20000.ethernet-ffffffff
>>>  DEV      PHY-ID  LINK
>>> 0x00  0x00070572  up
>>>
>> AFAICS there's no PHY driver yet for this model. The generic driver may or may not work.
>> Best add a PHY driver.
> 
> Hi Heiner
> 
> mscc.h:#define PHY_ID_VSC8531			  0x00070570
> 
> mscc_main.c:

OK, missed that. I just looked at the vitesse driver which also covers
a number of VSCxxxx PHY's.

>         .phy_id         = PHY_ID_VSC8531,
>         .name           = "Microsemi VSC8531",
>         .phy_id_mask    = 0xfffffff0,
>         /* PHY_GBIT_FEATURES */
>  
>> Any specific reason why you set the compatible to
>> ethernet-phy-ieee802.3-c45 for a c22 PHY?
> 
> Ah, i missed that! The driver only uses phy_read/phy_write, not
> phy_write_mmd() and phy_read_mmd().
> 
> Remove the compatible string. It is not needed for C22 PHYs.
> 
>        Andrew