From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Lin Liu" <lin.liu@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Shawn Anastasio" <sanastasio@raptorengineering.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Daniel P . Smith" <dpsmith@apertussolutions.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v5 04/16] xen/lib: Switch to xen/byteorder.h
Date: Mon, 31 Mar 2025 10:44:32 +0200 [thread overview]
Message-ID: <ba6adcbb-3192-4f82-bb8d-6df8f4fc3fe7@suse.com> (raw)
In-Reply-To: <20250328134427.874848-5-andrew.cooper3@citrix.com>
On 28.03.2025 14:44, Andrew Cooper wrote:
> From: Lin Liu <lin.liu@citrix.com>
>
> In divmod.c, additionally swap xen/lib.h for xen/macros.h as only ABS() is
> needed.
>
> In find-next-bit.c, ext2 has nothing to do with this logic.
While I agree here, ...
> Despite the
> comments, it was a local modification when the logic was imported from Linux,
> because Xen didn't have a suitable helper.
... I certainly can see functions of these names in Linux 2.6.16. Just in the
PA-RISC bitops.h, though. Yet this may be an indication that yet earlier on
this was a wider thing there.
> The new infrsatructure does have a suitable primitive, so use it.
>
> No functional change.
>
> Signed-off-by: Lin Liu <lin.liu@citrix.com>
Missing your own S-o-b?
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2025-03-31 8:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 13:44 [PATCH v5 00/16] xen: Centralise byteswap infrastructure Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 01/16] xen/lzo: Remove more remanants of TMEM Andrew Cooper
2025-03-31 7:30 ` Jan Beulich
2025-03-28 13:44 ` [PATCH v5 02/16] xen: Remove __{BIG,LITTLE}_ENDIAN_BITFIELD Andrew Cooper
2025-03-31 7:42 ` Jan Beulich
2025-03-31 14:08 ` Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 03/16] xen: Implement common byte{order,swap}.h Andrew Cooper
2025-03-31 8:32 ` Jan Beulich
2025-03-31 13:59 ` Andrew Cooper
2025-03-31 14:08 ` Jan Beulich
2025-03-28 13:44 ` [PATCH v5 04/16] xen/lib: Switch to xen/byteorder.h Andrew Cooper
2025-03-31 8:44 ` Jan Beulich [this message]
2025-03-28 13:44 ` [PATCH v5 05/16] xen/device-tree: Remove use of *_to_cpup() helpers Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 06/16] xen/decompressors: " Andrew Cooper
2025-03-28 14:07 ` Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 07/16] xen/arch: Switch to new byteorder infrastructure Andrew Cooper
2025-03-31 13:53 ` Jan Beulich
2025-03-28 13:44 ` [PATCH v5 08/16] xen/decompressors: Use " Andrew Cooper
2025-03-31 13:55 ` Jan Beulich
2025-03-28 13:44 ` [PATCH v5 09/16] xen: Remove old " Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 10/16] crypto/vmac: Switch to xen/byteswap.h Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 11/16] xsm/flask: Switch {asm -> xen}/byteorder.h Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 12/16] xen/common: " Andrew Cooper
2025-03-31 13:58 ` Jan Beulich
2025-03-28 13:44 ` [PATCH v5 13/16] arm: Remove asm/byteorder.h Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 14/16] ppc: Drop asm/byteorder.h Andrew Cooper
2025-03-28 13:44 ` [PATCH v5 15/16] riscv: Remove asm/byteorder.h Andrew Cooper
2025-03-31 14:52 ` Oleksii Kurochko
2025-03-28 13:44 ` [PATCH v5 16/16] x86: Drop asm/byteorder.h Andrew Cooper
2025-03-31 14:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba6adcbb-3192-4f82-bb8d-6df8f4fc3fe7@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=lin.liu@citrix.com \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.