From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15BAC77B7A for ; Tue, 6 Jun 2023 03:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232123AbjFFDqV (ORCPT ); Mon, 5 Jun 2023 23:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbjFFDqT (ORCPT ); Mon, 5 Jun 2023 23:46:19 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EA7218E for ; Mon, 5 Jun 2023 20:46:16 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-b9e6ec482b3so6309280276.3 for ; Mon, 05 Jun 2023 20:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=Lh96h/lDBcM3YSyz9v0Y3hvn7WuORPJViVjZHLCN9PyefN+x22jni/n5lbS1fhDzrP MpfKmVOs152zYpqX3g4u6c2D3DRgfMdP0/v6bviAT2MpzbSHHzT1WdHzhjJORbV5NjXz jTv8PNQ5uMu1rp4+lvGDpvPAo82GPLIFe4aaBe54H7wLp25+DpCiXVidTHgAusjDQEhI TJFlr+5pMFQolpJxSr6enqhcJJhZ9X5gzEO7McG7JDXjJjoYrjC13MU7AkvrFgfcVyfe eiqkT7oQJVsvZwL6YReJ17clGDoHjRRLJvavtOawvtgSEat8w13ANyRjIWkZ8nkQaS29 7W1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=amEzthTHMH6y8hPh47UU6WEr9OZKdsVjjYh2fd5uZ8XpTJTkMuxBDXVoZSacvEEUOO 2oX6zkBrlTJJAgrBr2Zg+NWJgPMbX0geWB88+Y/5ZIgzi1QLDRQUfE79HfR4lC+O1V+z 8J/vDdY28iG0GcPmT+DGp3FS2j41zypibFvMXSHGgPHElSVPbkgrqk9FT93OPPNFWMtq Ln6kYC9qMfjSNDDKNU+QCyCa+11mJoAK4lPqYX71+Yo6dorf907W4TtAfAA/NTYy6JoH 8IDK6YKOX9ebB4sXSOKbwjWkATsLurmBy/Qv8IOUinwAN6MY8vgGuLJizuWX2WGkSxYl 7BLA== X-Gm-Message-State: AC+VfDxDOun8sNRVu78njpgX/wQlJ7g0FqXkV2ZL+5E5UXPTtJIoiKB4 3L5nn4ENtuFp6/RpUBLx8xlXRQ== X-Google-Smtp-Source: ACHHUZ5ebo+2BnNCxDC86vNc4dj3ZHSCTA/lrxyp5IcLZWVSZfUvSH7wOGeKHnVgJiNuE/6SI1T17Q== X-Received: by 2002:a81:6dc6:0:b0:569:e7cb:c1d3 with SMTP id i189-20020a816dc6000000b00569e7cbc1d3mr1004573ywc.47.1686023175399; Mon, 05 Jun 2023 20:46:15 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id v80-20020a814853000000b0055a18d8479csm3761428ywa.21.2023.06.05.20.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 20:46:14 -0700 (PDT) Date: Mon, 5 Jun 2023 20:46:10 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Hugh Dickins cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Jann Horn , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/12] sparc: add pte_free_defer() for pgtables sharing page In-Reply-To: Message-ID: References: <35e983f5-7ed3-b310-d949-9ae8b130cdab@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Sun, 28 May 2023, Hugh Dickins wrote: > Add sparc-specific pte_free_defer(), to call pte_free() via call_rcu(). > pte_free_defer() will be called inside khugepaged's retract_page_tables() > loop, where allocating extra memory cannot be relied upon. This precedes > the generic version to avoid build breakage from incompatible pgtable_t. sparc32 supports pagetables sharing a page, but does not support THP; sparc64 supports THP, but does not support pagetables sharing a page. So the sparc-specific pte_free_defer() is as simple as the generic one, except for converting between pte_t *pgtable_t and struct page *. The patch should be fine as posted (except its title is misleading). > > Signed-off-by: Hugh Dickins > --- > arch/sparc/include/asm/pgalloc_64.h | 4 ++++ > arch/sparc/mm/init_64.c | 16 ++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h > index 7b5561d17ab1..caa7632be4c2 100644 > --- a/arch/sparc/include/asm/pgalloc_64.h > +++ b/arch/sparc/include/asm/pgalloc_64.h > @@ -65,6 +65,10 @@ pgtable_t pte_alloc_one(struct mm_struct *mm); > void pte_free_kernel(struct mm_struct *mm, pte_t *pte); > void pte_free(struct mm_struct *mm, pgtable_t ptepage); > > +/* arch use pte_free_defer() implementation in arch/sparc/mm/init_64.c */ > +#define pte_free_defer pte_free_defer > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); > + > #define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > #define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > > diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c > index 04f9db0c3111..b7c6aa085ef6 100644 > --- a/arch/sparc/mm/init_64.c > +++ b/arch/sparc/mm/init_64.c > @@ -2930,6 +2930,22 @@ void pgtable_free(void *table, bool is_page) > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static void pte_free_now(struct rcu_head *head) > +{ > + struct page *page; > + > + page = container_of(head, struct page, rcu_head); > + __pte_free((pgtable_t)page_to_virt(page)); > +} > + > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > +{ > + struct page *page; > + > + page = virt_to_page(pgtable); > + call_rcu(&page->rcu_head, pte_free_now); > +} > + > void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr, > pmd_t *pmd) > { > -- > 2.35.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C047BC77B7A for ; Tue, 6 Jun 2023 03:47:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QZxHy0PBWz3dtR for ; Tue, 6 Jun 2023 13:47:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=Lh96h/lD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::b2c; helo=mail-yb1-xb2c.google.com; envelope-from=hughd@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=Lh96h/lD; dkim-atps=neutral Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QZxGg13gvz3dy5 for ; Tue, 6 Jun 2023 13:46:18 +1000 (AEST) Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-ba8151a744fso6305169276.2 for ; Mon, 05 Jun 2023 20:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=Lh96h/lDBcM3YSyz9v0Y3hvn7WuORPJViVjZHLCN9PyefN+x22jni/n5lbS1fhDzrP MpfKmVOs152zYpqX3g4u6c2D3DRgfMdP0/v6bviAT2MpzbSHHzT1WdHzhjJORbV5NjXz jTv8PNQ5uMu1rp4+lvGDpvPAo82GPLIFe4aaBe54H7wLp25+DpCiXVidTHgAusjDQEhI TJFlr+5pMFQolpJxSr6enqhcJJhZ9X5gzEO7McG7JDXjJjoYrjC13MU7AkvrFgfcVyfe eiqkT7oQJVsvZwL6YReJ17clGDoHjRRLJvavtOawvtgSEat8w13ANyRjIWkZ8nkQaS29 7W1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=RvuGaKq8fPNJtJr4DsrZYYOYt+s5Kl2A+khOoIfAU6jhX8/qBQEixnLJOhKH3Sq2T+ YOKm7e2/WNiPVzMJI6oHK1lSDgXo4L31DgQBH2gJqboJmVJN+JrAgaUj7/oguj/YPSWx YzdnW/ItrIyCpS3LicKRDYAj51wwdcpWwtbu/av4Dz7CzMp3m1pIG6Bnmo62ATL8QDrt OnVYhzidXXxdS0YmgR7gvdRACl98fSTiar8wCi/63Shs0Ddbhx+z7mgpHrTHqWcIsWVW LB0kC2bGFCbqqpN83NfGH5mRmJ8U/OWZdlLi9bj/y55AJIXNeMZVXSHWXs2CW5zO/cl7 cOyA== X-Gm-Message-State: AC+VfDyIQJpUe9s3AqDeAaKKf7Ood89WlbROXTR7A2Pn99prY6RprsLf svYCX+e/um7X/7X65/KV7+c1Gw== X-Google-Smtp-Source: ACHHUZ5ebo+2BnNCxDC86vNc4dj3ZHSCTA/lrxyp5IcLZWVSZfUvSH7wOGeKHnVgJiNuE/6SI1T17Q== X-Received: by 2002:a81:6dc6:0:b0:569:e7cb:c1d3 with SMTP id i189-20020a816dc6000000b00569e7cbc1d3mr1004573ywc.47.1686023175399; Mon, 05 Jun 2023 20:46:15 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id v80-20020a814853000000b0055a18d8479csm3761428ywa.21.2023.06.05.20.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 20:46:14 -0700 (PDT) Date: Mon, 5 Jun 2023 20:46:10 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Hugh Dickins Subject: Re: [PATCH 06/12] sparc: add pte_free_defer() for pgtables sharing page In-Reply-To: Message-ID: References: <35e983f5-7ed3-b310-d949-9ae8b130cdab@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miaohe Lin , David Hildenbrand , Peter Zijlstra , Yang Shi , Peter Xu , Song Liu , sparclinux@vger.kernel.org, Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-s390@vger.kernel.org, Yu Zhao , Ira Weiny , Alistair Popple , Russell King , Matthew Wilcox , Steven Price , Christoph Hellwig , Jason Gunthorpe , "Aneesh Kumar K.V" , Axel Rasmussen , Christian Borntraeger , Thomas Hellstrom , Ralph Campbell , Pasha Tatashin , Anshuman Khandual , Heiko Ca rstens , Qi Zheng , Suren Baghdasaryan , linux-arm-kernel@lists.infradead.org, SeongJae Park , Jann Horn , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, "Kirill A. Shutemov" , Naoya Horiguchi , linux-kernel@vger.kernel.org, Minchan Kim , Mike Rapoport , Andrew Morton , Mel Gorman , "David S. Miller" , Zack Rusin , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, 28 May 2023, Hugh Dickins wrote: > Add sparc-specific pte_free_defer(), to call pte_free() via call_rcu(). > pte_free_defer() will be called inside khugepaged's retract_page_tables() > loop, where allocating extra memory cannot be relied upon. This precedes > the generic version to avoid build breakage from incompatible pgtable_t. sparc32 supports pagetables sharing a page, but does not support THP; sparc64 supports THP, but does not support pagetables sharing a page. So the sparc-specific pte_free_defer() is as simple as the generic one, except for converting between pte_t *pgtable_t and struct page *. The patch should be fine as posted (except its title is misleading). > > Signed-off-by: Hugh Dickins > --- > arch/sparc/include/asm/pgalloc_64.h | 4 ++++ > arch/sparc/mm/init_64.c | 16 ++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h > index 7b5561d17ab1..caa7632be4c2 100644 > --- a/arch/sparc/include/asm/pgalloc_64.h > +++ b/arch/sparc/include/asm/pgalloc_64.h > @@ -65,6 +65,10 @@ pgtable_t pte_alloc_one(struct mm_struct *mm); > void pte_free_kernel(struct mm_struct *mm, pte_t *pte); > void pte_free(struct mm_struct *mm, pgtable_t ptepage); > > +/* arch use pte_free_defer() implementation in arch/sparc/mm/init_64.c */ > +#define pte_free_defer pte_free_defer > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); > + > #define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > #define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > > diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c > index 04f9db0c3111..b7c6aa085ef6 100644 > --- a/arch/sparc/mm/init_64.c > +++ b/arch/sparc/mm/init_64.c > @@ -2930,6 +2930,22 @@ void pgtable_free(void *table, bool is_page) > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static void pte_free_now(struct rcu_head *head) > +{ > + struct page *page; > + > + page = container_of(head, struct page, rcu_head); > + __pte_free((pgtable_t)page_to_virt(page)); > +} > + > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > +{ > + struct page *page; > + > + page = virt_to_page(pgtable); > + call_rcu(&page->rcu_head, pte_free_now); > +} > + > void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr, > pmd_t *pmd) > { > -- > 2.35.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D97CCC7EE24 for ; Tue, 6 Jun 2023 03:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vW3xJPpYS+C8+ZGhoJ26LK129ff+s8rc453OHObhymY=; b=uKtVruW1+3HVX8 B8OvT/dHB2T8IGr+4QWZp+EfIKTm+PPaqp+cJALS0iW69u65Crju/f2Bw6dkTb2uDWoUbVWqMLuWi k/S0U25mB3WWukPcGEwIw3Yys0FFQcB+Ak598zCUmunTNvyx9eTA7AB37fGDFiNf46Vp44BbxRWtF UJJiZoY7UlrvjpmrdxicCyGQSZ60en4K9MiUiPOJU1cDmT4Gc5+3qHNjy2hm9cww0N2yqrmqTpshj vlwJzrsDFdF/SpZe+tZYdMdaJfpqb3fIAmcp4c1OeXJ3U/h9Z2RW4d5xaaKpRrXAK042ci8LsWA2A facJv9o4vTBM4Aot59DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6NeF-00022a-2w; Tue, 06 Jun 2023 03:46:19 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6NeD-00020h-0R for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2023 03:46:18 +0000 Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-ba8151a744fso6305172276.2 for ; Mon, 05 Jun 2023 20:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=Lh96h/lDBcM3YSyz9v0Y3hvn7WuORPJViVjZHLCN9PyefN+x22jni/n5lbS1fhDzrP MpfKmVOs152zYpqX3g4u6c2D3DRgfMdP0/v6bviAT2MpzbSHHzT1WdHzhjJORbV5NjXz jTv8PNQ5uMu1rp4+lvGDpvPAo82GPLIFe4aaBe54H7wLp25+DpCiXVidTHgAusjDQEhI TJFlr+5pMFQolpJxSr6enqhcJJhZ9X5gzEO7McG7JDXjJjoYrjC13MU7AkvrFgfcVyfe eiqkT7oQJVsvZwL6YReJ17clGDoHjRRLJvavtOawvtgSEat8w13ANyRjIWkZ8nkQaS29 7W1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686023175; x=1688615175; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PlaL5MaaVR+UDyIKMcm/yVvL4j9So7q5GkztpswdgME=; b=KWa5kV4BuBiCQt0T6tKuBIG72HEpDpzWwrI/enTN1eZQmBFEaeH7IAXSs0y9xKyrKJ uxlPOw7/4CuC8teMjOweXlYr/qjQo/nskgEecdus/gemUBRAoSOQgkMflF/q+i7UJYjF HBPsvNbbue9K0NLAoKntBAg9uTns/xU2H2gqgoikF68FJ4lhMt0Am31c77d1j3b/E299 1vG7dZDeFJXkyjvYL3QfD+n4X2oAaUC+vfND+VNpC0WFSQWhDolOoGduXv581kA0LY/u 7RaNypaoNl2CKBrNBm3AFEoMk+DbMDHoRuBsBQMGVWUbSYE2q/nWuIwjy+wegkq/mDkX dLoQ== X-Gm-Message-State: AC+VfDzLe0xH1B7ORRbwHSb7NRHVtyXdm2U7ZWzUoxok7VPExEeRcbkT Egw6akkBAAgv7/dWiXKFAgKsGA== X-Google-Smtp-Source: ACHHUZ5ebo+2BnNCxDC86vNc4dj3ZHSCTA/lrxyp5IcLZWVSZfUvSH7wOGeKHnVgJiNuE/6SI1T17Q== X-Received: by 2002:a81:6dc6:0:b0:569:e7cb:c1d3 with SMTP id i189-20020a816dc6000000b00569e7cbc1d3mr1004573ywc.47.1686023175399; Mon, 05 Jun 2023 20:46:15 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id v80-20020a814853000000b0055a18d8479csm3761428ywa.21.2023.06.05.20.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 20:46:14 -0700 (PDT) Date: Mon, 5 Jun 2023 20:46:10 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Hugh Dickins cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Jann Horn , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/12] sparc: add pte_free_defer() for pgtables sharing page In-Reply-To: Message-ID: References: <35e983f5-7ed3-b310-d949-9ae8b130cdab@google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_204617_175600_C3BA814F X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 28 May 2023, Hugh Dickins wrote: > Add sparc-specific pte_free_defer(), to call pte_free() via call_rcu(). > pte_free_defer() will be called inside khugepaged's retract_page_tables() > loop, where allocating extra memory cannot be relied upon. This precedes > the generic version to avoid build breakage from incompatible pgtable_t. sparc32 supports pagetables sharing a page, but does not support THP; sparc64 supports THP, but does not support pagetables sharing a page. So the sparc-specific pte_free_defer() is as simple as the generic one, except for converting between pte_t *pgtable_t and struct page *. The patch should be fine as posted (except its title is misleading). > > Signed-off-by: Hugh Dickins > --- > arch/sparc/include/asm/pgalloc_64.h | 4 ++++ > arch/sparc/mm/init_64.c | 16 ++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/arch/sparc/include/asm/pgalloc_64.h b/arch/sparc/include/asm/pgalloc_64.h > index 7b5561d17ab1..caa7632be4c2 100644 > --- a/arch/sparc/include/asm/pgalloc_64.h > +++ b/arch/sparc/include/asm/pgalloc_64.h > @@ -65,6 +65,10 @@ pgtable_t pte_alloc_one(struct mm_struct *mm); > void pte_free_kernel(struct mm_struct *mm, pte_t *pte); > void pte_free(struct mm_struct *mm, pgtable_t ptepage); > > +/* arch use pte_free_defer() implementation in arch/sparc/mm/init_64.c */ > +#define pte_free_defer pte_free_defer > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable); > + > #define pmd_populate_kernel(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > #define pmd_populate(MM, PMD, PTE) pmd_set(MM, PMD, PTE) > > diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c > index 04f9db0c3111..b7c6aa085ef6 100644 > --- a/arch/sparc/mm/init_64.c > +++ b/arch/sparc/mm/init_64.c > @@ -2930,6 +2930,22 @@ void pgtable_free(void *table, bool is_page) > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static void pte_free_now(struct rcu_head *head) > +{ > + struct page *page; > + > + page = container_of(head, struct page, rcu_head); > + __pte_free((pgtable_t)page_to_virt(page)); > +} > + > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > +{ > + struct page *page; > + > + page = virt_to_page(pgtable); > + call_rcu(&page->rcu_head, pte_free_now); > +} > + > void update_mmu_cache_pmd(struct vm_area_struct *vma, unsigned long addr, > pmd_t *pmd) > { > -- > 2.35.3 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel