All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Vladimir Murzin <vladimir.murzin@arm.com>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>,
	<mark.rutland@arm.com>, <lpieralisi@kernel.org>,
	<liaochang1@huawei.com>, <ashok.raj@oss.qualcomm.com>,
	<maz@kernel.org>
Subject: Re: [PATCH v2 00/39] arm64: Add support for FEAT_NMI
Date: Thu, 19 Nov 2026 10:33:21 +0800	[thread overview]
Message-ID: <ba8c4dc9-de83-42bd-99b9-e97517df2ce8@huawei.com> (raw)
In-Reply-To: <986b9a9c-078e-4cf1-b809-b606e2892b25@arm.com>



在 2026/11/18 21:22, Vladimir Murzin 写道:
> Hi Jinjie,

Hi Vladimir,

> 
> On 11/16/26 11:01, Jinjie Ruan wrote:
>>
>> 在 2026/11/16 18:02, Vladimir Murzin 写道:
>>> Hi Jinjie,
>>>
>>> On 11/16/26 06:58, Jinjie Ruan wrote:
>>>> Hi, Vladimir,
>>>>
>>>> While testing this patch set, I discovered IPI as NMI now defaults to
>>>> using SDEI, and the FEAT_NMI cannot cover this path..
>>>>
>>> Can you please expand on that? Sashiko has several comments related to
>>> interaction with SDEI which I'm planing to dig into. However, glancing
>> I mean the following code now prefer sdei nmi now, we can not use FEAT_NMI:
>>
>>  954 void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int
>> exclude_cpu)
>>  955 {
>>  956         /*
>>  957          * Prefer the SDEI cross-CPU NMI provider when active: firmware
>>  958          * dispatches the event out of EL3 and reaches CPUs that have
>>  959          * interrupts locally masked, without the per-IRQ-mask cost
>> that
>>  960          * pseudo-NMI pays for the same reach. The plain IPI path below
>>  961          * can't reach such a CPU unless pseudo-NMI is enabled.
>>  962          */
>>  963         if (sdei_nmi_trigger_cpumask_backtrace(mask, exclude_cpu))
>>  964                 return;
>>  965
>>  966         /*
>>  967          * NOTE: though nmi_trigger_cpumask_backtrace() has "nmi_"
>> in the name,
>>  968          * nothing about it truly needs to be implemented using an
>> NMI, it's
>>  969          * just that it's _allowed_ to work with NMIs. If
>> ipi_should_be_nmi()
>>  970          * returned false our backtrace attempt will just use a
>> regular IPI.
>>  971          */
>>  972         nmi_trigger_cpumask_backtrace(mask, exclude_cpu,
>> arm64_backtrace_ipi);
>>  973 }
>>
>>
> 
> Ahh, I did not notice that. Perhaps we can do something like bellow
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index c4d1aff31258..17da29f4a7ec 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -955,8 +955,24 @@ static void arm64_backtrace_ipi(cpumask_t *mask)
>         arm64_send_ipi(mask, IPI_CPU_BACKTRACE);
>  }
>  
> +static bool arm64_nmi_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu)
> +{
> +       if (!ipi_is_nmi(smp_processor_id(), IPI_CPU_BACKTRACE))
> +               return false;

This false case should be Pseudo-NMI and IRQ.

> +
> +       nmi_trigger_cpumask_backtrace(mask, exclude_cpu, arm64_backtrace_ipi);
> +
> +       return true;

This is FEAT_NMI

> +}
> +
>  void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu)
>  {
> +       /*
> +        * Backtrace IPI is NMI, use that.
> +        */
> +       if (arm64_nmi_trigger_cpumask_backtrace(mask, exclude_cpu))
> +               return;
> +
>         /*
>          * Prefer the SDEI cross-CPU NMI provider when active: firmware
>          * dispatches the event out of EL3 and reaches CPUs that have
> 
> 
> So, preference order would be NMI -> SDEI NMI -> IRQ. My understanding that

Based on the motivation of the cross CPU SDEI patch, I guess the order
should be as follows:

FEAT_NMI > SDEI NMI > Pseudo-NMI > IRQ

> users of SDEI NMI do not opt-in for pseudo-NMI so they get what they want, and

My understanding is the same.

> if they do not want FEAT_NMI they can opt-out via id_aa64pfr1.nmi=0.

I believe this situation is relatively rare and does not seem to align
with the original intent of SDEI NMI. In its cover letter, there is the
following statement, and I understand that if hardware supports FEAT_NMI
should be used as the default first priority.

"FEAT_NMI (Armv8.8) -- the architectural fix, but absent from deployed
    silicon and from most of the fleet for years to come."

Link: https://lore.kernel.org/all/cover.1782744912.git.kas@kernel.org/

> 
> If it makes sense to you I'll include it in the series as separate patch.
> 
> Cheers
> Vladimir
> 
>>> over smp_send_stop() IPI as NMI is kind of try and see approach:
>>>
>>>   try normal IPI
>>>   if CPU is still online
>>>     try NMI IPI
>>>   if CPU is still online
>>>    try SDEI NMI
>>>   if CPU is still online
>>>    give up
>>>
>>> So, if NMI IPI did not trigger in your test, I'm really keen on details.
>>>
>>> Thanks
>>> Vladimir
>>
> 



  reply	other threads:[~2026-11-19  2:33 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 13:20 [PATCH v2 00/39] arm64: Add support for FEAT_NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 01/39] arm64: irqflags: Introduce arm64-specific irqflags type Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 02/39] arm64: irqflags: save and use both DAIF and PMR Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 03/39] arm64: interrupts: Add common exception state helpers Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 04/39] arm64: process: Lift check for exception state to generic infrastructure Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 05/39] arm64: entry: Introduce entry specific exception masking helpers Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 06/39] arm64: entry: replace DAIF helpers with entry helpers Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 07/39] arm64: interrupts: Introduce exception masking save/restore helpers Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 08/39] arm64: interrupts: introduce a helper for GIC priority initialization Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 09/39] arm64: replace local_daif helpers Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 10/39] arm64: cpuidle: use new helpers to bypass interrupt priority masking Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 11/39] arm64: remove daifflags.h Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 12/39] arm64: gicv3: remove GIC_PRIO_PSR_I_SET Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 13/39] arm64: cpufeature: Remove system_has_prio_mask_debugging() Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 14/39] arm64: irqflags: Switch to CONFIG_DEBUG_IRQFLAGS Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 15/39] arm64: Kconfig: Remove CONFIG_ARM64_DEBUG_PRIORITY_MASKING Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 16/39] efi/runtime-wrappers: Permit architectures to override IRQ flags checks Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 17/39] arm64/efi: Implement override for " Vladimir Murzin
2026-11-13 13:22   ` Mark Brown
2026-11-12 13:20 ` [PATCH v2 18/39] arm64: booting: Document boot requirements for FEAT_NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 19/39] arm64: sysreg: Add definitions for immediate versions of MSR ALLINT Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 20/39] arm64: probes: Reject stepping over ALLINT Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 21/39] arm64: ptrace: Add PSR_ALLINT_BIT Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 22/39] arm64: idreg: Add an override for FEAT_NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 23/39] arm64: cpufeature: Detect PE support " Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 24/39] arm64: nmi: Manage masking for superpriority interrupts Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 25/39] arm64: irq: Report FEAT_NMI masking local IRQs Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 26/39] arm64: nmi: Add handling of superpriority interrupts as NMIs Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 27/39] arm64: suspend: Always initialise PSTATE.ALLINT Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 28/39] arm64/efi: Add ALLINT to IRQ flags checks Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 29/39] arm64: kprobes: Disable NMIs Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 30/39] arm64: smp: Abstract SGI and LPI operations Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 31/39] arm64: smp: Fall back to IRQ when IPI NMI request fails Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 32/39] arm64: nmi: Add Kconfig for NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 33/39] arm64: nmi: Select HAVE_PERF_EVENTS_NMI for FEAT_NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 34/39] irqchip/gic-v3: Rename nmi to pseudo_nmi Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 35/39] irqchip/gic-v3: Implement FEAT_GICv3_NMI support Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 36/39] arm64: smp: Add NMI support for LPI-backed IPIs Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 37/39] genirq: Trust local irqchip when considering IRQ for NMI Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 38/39] genirq: Do not call add_interrupt_randomness() in NMI context Vladimir Murzin
2026-11-12 13:20 ` [PATCH v2 39/39] irqchip/gic-v5: Add NMI support Vladimir Murzin
2026-11-14  5:03 ` [PATCH v2 00/39] arm64: Add support for FEAT_NMI Ashok Raj
2026-11-19 11:18   ` Vladimir Murzin
2026-11-16  6:58 ` Jinjie Ruan
2026-11-16 10:02   ` Vladimir Murzin
2026-11-16 11:01     ` Jinjie Ruan
2026-11-18 13:22       ` Vladimir Murzin
2026-11-19  2:33         ` Jinjie Ruan [this message]
2026-11-18 12:17 ` Jinjie Ruan
2026-11-19  1:54   ` Jinjie Ruan
2026-11-19 10:14     ` Vladimir Murzin
2026-11-19 12:45       ` Jinjie Ruan
2026-11-19 14:50         ` Vladimir Murzin
2026-11-19 16:07           ` Kiryl Shutsemau (Meta)
2026-11-19 16:38             ` Kiryl Shutsemau (Meta)
2026-11-20  2:11             ` Jinjie Ruan
2026-11-20 15:07               ` Kiryl Shutsemau (Meta)
2026-11-19 11:41   ` Jinjie Ruan
2026-11-19 14:46     ` Vladimir Murzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba8c4dc9-de83-42bd-99b9-e97517df2ce8@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=ashok.raj@oss.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=liaochang1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.