From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly
Date: Tue, 19 Mar 2024 17:49:02 +0100 [thread overview]
Message-ID: <baa244dc-eec4-43ea-bc0a-41f3e4340975@suse.com> (raw)
In-Reply-To: <20240319144802.3894710-2-andrew.cooper3@citrix.com>
On 19.03.2024 15:48, Andrew Cooper wrote:
> Right now, if the user requests the watchdog on the command line,
> setup_apic_nmi_watchdog() will blindly assume that setting up the watchdog
> worked. Reuse nmi_perfctr_msr to identify when the watchdog has been set up.
>
> Rearrange setup_p6_watchdog() to not set nmi_perfctr_msr until the sanity
> checks are performed. Turn setup_p4_watchdog() into a void function, matching
> the others.
>
> If the watchdog isn't set up, inform the user and override to NMI_NONE, which
> will prevent check_nmi_watchdog() from claiming that all CPUs are stuck.
>
> e.g.:
>
> (XEN) alt table ffff82d040697c38 -> ffff82d0406a97f0
> (XEN) Failed to configure NMI watchdog
> (XEN) Brought up 512 CPUs
> (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2024-03-19 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:48 [PATCH 0/2] x86/boot: More watchdog fixes Andrew Cooper
2024-03-19 14:48 ` [PATCH 1/2] x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly Andrew Cooper
2024-03-19 16:49 ` Jan Beulich [this message]
2024-03-19 14:48 ` [PATCH 2/2] x86/boot: Support the watchdog on newer AMD systems Andrew Cooper
2024-03-19 16:51 ` Jan Beulich
2024-03-19 16:54 ` Andrew Cooper
2024-03-19 16:53 ` [PATCH 0/2] x86/boot: More watchdog fixes Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa244dc-eec4-43ea-bc0a-41f3e4340975@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.