From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2B3CC83F2C for ; Mon, 4 Sep 2023 07:19:52 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.594995.928456 (Exim 4.92) (envelope-from ) id 1qd3ri-0006WV-Gv; Mon, 04 Sep 2023 07:19:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 594995.928456; Mon, 04 Sep 2023 07:19:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qd3ri-0006WO-EF; Mon, 04 Sep 2023 07:19:18 +0000 Received: by outflank-mailman (input) for mailman id 594995; Mon, 04 Sep 2023 07:19:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qd3rh-0006WI-1j for xen-devel@lists.xenproject.org; Mon, 04 Sep 2023 07:19:17 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58b76b78-4af3-11ee-9b0d-b553b5be7939; Mon, 04 Sep 2023 09:19:12 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7E42B4EE0737; Mon, 4 Sep 2023 09:19:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58b76b78-4af3-11ee-9b0d-b553b5be7939 MIME-Version: 1.0 Date: Mon, 04 Sep 2023 09:19:12 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/2] xen: apply deviation for Rule 8.4 (asm-only definitions) In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/09/2023 09:02, Jan Beulich wrote: > On 01.09.2023 18:34, Nicola Vetrini wrote: >> As stated in 'docs/misra/rules.rst' the functions that are used only >> by >> asm modules do not need to conform to MISRA C:2012 Rule 8.4. >> The deviations are carried out with a SAF comment. >> >> Signed-off-by: Nicola Vetrini >> --- >> Where the identifier for a function definition is on the next line >> w.r.t. the >> return type, they have been put on the same line (e.g. efi_start) to >> avoid >> stylistically questionable constructs, such as >> >> int >> /* SAF-1-safe */ >> func(void) { >> ... >> } > > And > > /* SAF-1-safe */ > int > func(void) { > > is not an option? > Not at the moment, as it would deviate the line with the return type and not the one below, and this is not configurable in the scripts under xen/scripts/xen-analysis: /* SAF-1-safe */ -> /* -E> safe ... 1 */ int int func(void) func(void) As I said, this can perhaps be solved by allowing markers to specify either a row count, such as /* SAF-1-safe 2 */ -> /* -E> safe ... 2 */ int int func(void) func(void) or count the line span of the whole function declarator in the python script and translating /* SAF-1-safe */ -> /* -E> safe ... 2 */. > Further in the cover letter you say "Deviating variables needs more > care, and > is therefore postponed to another patch", yet then here you annotate a > couple > of variables as well. Could you clarify what the criteria are for > "needs more > care"? > I see. I did not intend for those changes to end up in this patch, although those two are clearly only used by asm code and therefore are excepted. Most of the variables I left out are also used by C code, therefore they may be eligible for a declaration, but where to put this declaration requires a careful examination in my opinion. They are not too many, tough. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)