From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9522D68BCD for ; Fri, 15 Nov 2024 18:03:45 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.837961.1253869 (Exim 4.92) (envelope-from ) id 1tC0f7-0006lA-IY; Fri, 15 Nov 2024 18:03:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 837961.1253869; Fri, 15 Nov 2024 18:03:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tC0f7-0006l3-Fn; Fri, 15 Nov 2024 18:03:17 +0000 Received: by outflank-mailman (input) for mailman id 837961; Fri, 15 Nov 2024 18:03:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tC0f6-0006kx-La for xen-devel@lists.xenproject.org; Fri, 15 Nov 2024 18:03:16 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e032dc6a-a37b-11ef-a0c7-8be0dac302b0; Fri, 15 Nov 2024 19:03:11 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a9e44654ae3so150413866b.1 for ; Fri, 15 Nov 2024 10:03:11 -0800 (PST) Received: from [10.125.226.166] ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20df52adasm200289366b.81.2024.11.15.10.03.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 10:03:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e032dc6a-a37b-11ef-a0c7-8be0dac302b0 X-Custom-Connection: eyJyZW1vdGVpcCI6IjJhMDA6MTQ1MDo0ODY0OjIwOjo2MmMiLCJoZWxvIjoibWFpbC1lajEteDYyYy5nb29nbGUuY29tIn0= X-Custom-Transaction: eyJpZCI6ImUwMzJkYzZhLWEzN2ItMTFlZi1hMGM3LThiZTBkYWMzMDJiMCIsInRzIjoxNzMxNjkzNzkxLjExMTU1MSwic2VuZGVyIjoiYW5kcmV3LmNvb3BlckBjbG91ZC5jb20iLCJyZWNpcGllbnQiOiJ4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcifQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1731693790; x=1732298590; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Vt8YeGqOnwZKJLkShM7ZkBWKYwFJg/rg9MhZxk65vhw=; b=f8YEOurfxodKKQRcGTekJp1o6iOkrWEi3Qr/OqRlZZYaThyIbepOFI7REOhf0yZcLh Jsr/4q6zVtzXQH5GK1YX8mb3QdxfQeYtDKzaZH3UucZkYY2BUcRqXLTq2X8Ov4OscdNh NLPkAv6mVYoZ/H3gCPQlsqu5JsbjME4WXdmRQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731693790; x=1732298590; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vt8YeGqOnwZKJLkShM7ZkBWKYwFJg/rg9MhZxk65vhw=; b=IdxMsWaeNmhRkWjY5ydCVdpZ2vvYCEIIbD2/DOYEDshWUgG5OW0o6SY0iUAJrViYgM 7qttcnSVXQyuBoG8RaU3Yb2tm8yfmt0v5j7uH3YYIlpvov7/bX+VzG8KZ/RQ+maxegh3 WZJ/vRR723P0LettwJJb52rzrTzqe+IjO41rTFYdKUVbLtqlIXynWpUzQtWC17LkeYrj /GrbbHFEQ0fsPJf4rlb1VDH89nZRq2gpuirKpo41V10zgHeLMAvbsh9EeJ0gf4wR4kai TchjNQ7i9XVvaLgCdROOkjG2xrNbql865mLg24UeQIPQ3Ok25ccHK50lk4LlM0iWwBxM +Ang== X-Forwarded-Encrypted: i=1; AJvYcCUMmZM16tAGwO1e4Almrci0hwFrA0P4FX3l3NpTOAL4j5ABOMWxpqbr+rBwKeVnvNaPagmNftwC8Ws=@lists.xenproject.org X-Gm-Message-State: AOJu0YwBssTjxQODVaZx4ap/yn3x0BA45CYTfxpGOPN0UNjKygqHO6yp FYwOCGlg5A4VgkvZpeR20iq4Awl92yUu15n1H8DczQ+qADXAxzJYqrVrPuibGFU= X-Google-Smtp-Source: AGHT+IGUozI8F4mrCu2bmBqoHIiwvjn7trJgIWFxlGK79bR8ELRiziuVbTq3Ifdo4baH7MNN1x7HtA== X-Received: by 2002:a17:907:36cb:b0:a9e:b1f9:bc52 with SMTP id a640c23a62f3a-aa48354d1d5mr331312466b.55.1731693789884; Fri, 15 Nov 2024 10:03:09 -0800 (PST) Message-ID: Date: Fri, 15 Nov 2024 18:03:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] x86/ucode: Fix cache handling in microcode_update_helper() To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Xen-devel References: <20241112211915.1473121-1-andrew.cooper3@citrix.com> <20241112211915.1473121-3-andrew.cooper3@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/11/2024 11:26 am, Jan Beulich wrote: > On 12.11.2024 22:19, Andrew Cooper wrote: >> microcode_update_cache() now has a single caller, but inlining it shows how >> unnecessarily complicated the logic really is. >> >> Outside of error paths, there is always one microcode patch to free. Its >> either result of parse_blob(), or it's the old cached value. >> >> In order to fix this, have a local patch pointer (mostly to avoid the >> unnecessary verbosity of patch_with_flags.patch), and always free it at the >> end. The only error path needing care is the IS_ERR(patch) path, which is >> easy enough to handle. >> >> Also, widen the scope of result. We only need to call compare_patch() once, >> and the answer is still good later when updating the cache. In order to >> update the cache, simply SWAP() the patch and the cache pointers, allowing the >> singular xfree() at the end to cover both cases. >> >> This also removes all callers microcode_free_patch() which fixes the need to >> cast away const to allow it to compile. > I'm sure you're well aware that this in turn is just because of your opposition > to xfree() and alike taking const void *. My opposition, and the C standards committee, and MISRA to name but a few. > Pointers needing to be to non-const > just because of eventual freeing is precisely the scenario why freeing (and > unmapping) functions better wouldn't take mutable pointers. Then ... > >> --- a/xen/arch/x86/cpu/microcode/core.c >> +++ b/xen/arch/x86/cpu/microcode/core.c >> @@ -86,7 +86,7 @@ struct patch_with_flags { >> static bool ucode_in_nmi = true; >> >> /* Protected by microcode_mutex */ >> -static const struct microcode_patch *microcode_cache; >> +static struct microcode_patch *microcode_cache; > ... this imo pretty undesirable change also wouldn't be needed. > > Nevertheless, in the interest of not blocking this change over a long-standing > disagreement we have, > Reviewed-by: Jan Beulich Thankyou. ~Andrew