From: David Ahern <dsahern@kernel.org>
To: Rastislav Szabo <rastislav.szabo@isovalent.com>, netdev@vger.kernel.org
Cc: edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, dima@arista.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 2/2] selftests: net: tcp_ao: test VRF-scoped key deletion
Date: Fri, 21 Aug 2026 12:35:34 -0600 [thread overview]
Message-ID: <bacc585b-8b2d-47fc-b26a-83854a931bc0@kernel.org> (raw)
In-Reply-To: <20260821153823.266343-2-rastislav.szabo@isovalent.com>
On 8/21/26 9:38 AM, Rastislav Szabo wrote:
> Verify that TCP_AO_DEL_KEY can remove a TCP-AO key scoped to a VRF.
>
> Assisted-by: Codex:GPT-5
> Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
> ---
> .../selftests/net/tcp_ao/key-management.c | 66 ++++++++++++-------
> .../testing/selftests/net/tcp_ao/lib/aolib.h | 6 +-
> tools/testing/selftests/net/tcp_ao/lib/sock.c | 4 +-
> 3 files changed, 51 insertions(+), 25 deletions(-)
>
> diff --git a/tools/testing/selftests/net/tcp_ao/key-management.c b/tools/testing/selftests/net/tcp_ao/key-management.c
> index d86bb380b79f..1e01e805dba7 100644
> --- a/tools/testing/selftests/net/tcp_ao/key-management.c
> +++ b/tools/testing/selftests/net/tcp_ao/key-management.c
> @@ -63,7 +63,8 @@ static int prepare_lsk(union tcp_addr *addr, uint8_t sndid, uint8_t rcvid)
> return sk;
> }
>
> -static int test_del_key(int sk, uint8_t sndid, uint8_t rcvid, bool async,
> +static int test_del_key(int sk, uint8_t sndid, uint8_t rcvid, int ifindex,
> + bool async,
> int current_key, int rnext_key)
The new async can be put on the line with current_key.
Other than that nit:
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2026-08-21 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 15:38 [PATCH net 1/2] net/tcp: fix TCP-AO key deletion in VRFs Rastislav Szabo
2026-08-21 15:38 ` [PATCH net 2/2] selftests: net: tcp_ao: test VRF-scoped key deletion Rastislav Szabo
2026-08-21 18:35 ` David Ahern [this message]
2026-08-22 4:02 ` Dmitry Safonov
2026-08-21 18:33 ` [PATCH net 1/2] net/tcp: fix TCP-AO key deletion in VRFs David Ahern
2026-08-22 3:53 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacc585b-8b2d-47fc-b26a-83854a931bc0@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rastislav.szabo@isovalent.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.