From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ryszard.knop@intel.com, Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH topic/core-for-CI] Revert "ftrace: Allow configuring global trace buffer size (for dump-on-oops)"
Date: Thu, 03 Jul 2025 10:35:13 +0300 [thread overview]
Message-ID: <bad8ddb51d688adef738973cdc12916f7c022aae@intel.com> (raw)
In-Reply-To: <20250630151728.316208-2-lucas.demarchi@intel.com>
On Mon, 30 Jun 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> This reverts commit 41e750b906022da3e4fb9dc57bc17670a340ad23.
>
> It's not used in CI anymore, probably for a very long time. So we don't
> need maintain this in topic/core-for-CI.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> kernel/trace/Kconfig | 7 -------
> kernel/trace/trace.c | 4 +++-
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 012db82731e29..a3f35c7d83b6c 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -176,13 +176,6 @@ config TRACING
> select TRACE_CLOCK
> select NEED_TASKS_RCU
>
> -config GLOBAL_TRACE_BUF_SIZE
> - int
> - prompt "Global ftrace buffer size (for trace_printk)" if EXPERT
> - range 0 4194034
> - default 1441792 # 16384 * 88 (sizeof(struct print_entry))
> - depends on TRACING
> -
> config GENERIC_TRACER
> bool
> select TRACING
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index dc8ac10db04f2..95ae7c4e58357 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -950,7 +950,9 @@ int tracing_is_enabled(void)
> * to not have to wait for all that output. Anyway this can be
> * boot time and run time configurable.
> */
> -static unsigned long trace_buf_size = CONFIG_GLOBAL_TRACE_BUF_SIZE;
> +#define TRACE_BUF_SIZE_DEFAULT 1441792UL /* 16384 * 88 (sizeof(entry)) */
> +
> +static unsigned long trace_buf_size = TRACE_BUF_SIZE_DEFAULT;
>
> /* trace_types holds a link list of available tracers. */
> static struct tracer *trace_types __read_mostly;
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-07-03 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 15:17 [PATCH topic/core-for-CI] Revert "ftrace: Allow configuring global trace buffer size (for dump-on-oops)" Lucas De Marchi
2025-06-30 18:56 ` ✓ i915.CI.BAT: success for " Patchwork
2025-07-01 5:03 ` ✓ CI.KUnit: " Patchwork
2025-07-01 5:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-01 12:13 ` ✗ i915.CI.Full: failure " Patchwork
2025-07-02 19:33 ` ✗ Xe.CI.Full: " Patchwork
2025-07-03 7:35 ` Jani Nikula [this message]
2025-07-03 15:33 ` [PATCH topic/core-for-CI] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bad8ddb51d688adef738973cdc12916f7c022aae@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=ryszard.knop@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.