Re: [Buildroot] [PATCH v3 10/11] package/qoriq-restool: new package

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Vladimir,

Thanks for the patch!

On my side, it generates few build failures with test-pkg, when running
the command:

     utils/test-pkg -a -p qoriq-restool

I'm expecting no build failure. So either there is missing requirements
in Config.in, or it is bugs in the code.

Could you have a look please?

On 11/08/2025 18:55, Vladimir Oltean wrote:
> Introduce a package for the restool program, which permits the user to
> modify the network configuration of the DPAA2 subsystem and create one
> that is adequate to their use case.
> 
> We integrate the lf-6.12.20-2.0.0 release tag, which contains some 
> extra
> fixups specifically made for the Buildroot integration:
> - commit 14a9058c772b ("manpage: it should be optional"): It was 
> pointed
>   out on previous patch submissions that the "make install" target also
>   converts man pages from Markdown to groff using pandoc, and apart 
> from
>   the fact that Buildroot doesn't want manpages, pandoc is also too
>   heavy to drag into the build system. So that feedback was considered
>   valid and the patch is included here via upstream.
> - commit 6d6b9d8c200c ("dpdmux: remove unused dpdmux_create_options
>   array") addresses a build error
> - commit 66d941a0160d ("Adapt BITS_PER_LONG and GENMASK() definitions
>   for 32-bit compatibility") addresses a build error on 32-bit builds
> - commit 8f73f2600111 ("Print 64-bit counters using PRIu64 from
>   inttypes.h") addresses a build error on 32-bit builds
> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reviewed-by: Vincent Jardin <vjardin@free.fr>
> ---
> v2->v3: integrate upstream a patch which fixes 32-bit builds
> v1->v2: integrate upstream a patch from Vincent which avoids building
>         man pages
> 
>  DEVELOPERS                               |  1 +
>  package/Config.in                        |  1 +
>  package/qoriq-restool/Config.in          | 22 +++++++++++++++++++++
>  package/qoriq-restool/qoriq-restool.hash |  3 +++
>  package/qoriq-restool/qoriq-restool.mk   | 25 ++++++++++++++++++++++++
>  5 files changed, 52 insertions(+)
>  create mode 100644 package/qoriq-restool/Config.in
>  create mode 100644 package/qoriq-restool/qoriq-restool.hash
>  create mode 100644 package/qoriq-restool/qoriq-restool.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 12a41597afb0..1b5b3e87ea04 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3432,6 +3432,7 @@ F:	package/qoriq-ddr-phy-binary/
>  F:	package/qoriq-firmware-inphi/
>  F:	package/qoriq-mc-binary/
>  F:	package/qoriq-mc-utils/
> +F:	package/qoriq-restool/
> 
>  N:	Volkov Viacheslav <sv99@inbox.ru>
>  F:	package/v4l2grab/
> diff --git a/package/Config.in b/package/Config.in
> index 137f74ed82ce..ccf76af1cc21 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -598,6 +598,7 @@ endmenu
>  	source "package/pru-software-support/Config.in"
>  	source "package/pulseview/Config.in"
>  	source "package/qoriq-cadence-dp-firmware/Config.in"
> +	source "package/qoriq-restool/Config.in"
>  	source "package/raspi-gpio/Config.in"
>  	source "package/rdma-core/Config.in"
>  	source "package/read-edid/Config.in"
> diff --git a/package/qoriq-restool/Config.in 
> b/package/qoriq-restool/Config.in
> new file mode 100644
> index 000000000000..dbe0934d4dd3
> --- /dev/null
> +++ b/package/qoriq-restool/Config.in
> @@ -0,0 +1,22 @@
> +config BR2_PACKAGE_QORIQ_RESTOOL
> +	bool "qoriq-restool"
> +	help
> +	  The DPAA2 architecture in Layerscape SoCs consists of
> +	  networking resources that can be assembled into various
> +	  nuggets of functionality, called "objects" (DPMAC, DPNI,
> +	  DPDMUX, DPSW etc), by the Management Complex (MC) firmware.
> +
> +	  The MC firmware reads a file called Data Path Layout (DPL)
> +	  which describes the set of networking objects it should
> +	  create statically, at boot time.
> +
> +	  The restool program is able to talk to the Management
> +	  Complex at runtime and permits the dynamic reconfiguration
> +	  of networking objects, as well as saving the current
> +	  configuration into a new DPL file. Without the restool
> +	  program, the only possible networking configuration is
> +	  that specified in the boot-time DPL file.
> +
> +	  https://github.com/nxp-qoriq/restool
> +	  # sign in required
> +	  https://www.nxp.com/webapp/Download?colCode=DPAA2UM
> diff --git a/package/qoriq-restool/qoriq-restool.hash 
> b/package/qoriq-restool/qoriq-restool.hash
> new file mode 100644
> index 000000000000..5e11f60d0e74
> --- /dev/null
> +++ b/package/qoriq-restool/qoriq-restool.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  
> efc3c21c04adef30d7903e6ce4923ca085dad7e53351ce21b6bfafd681ae8674  
> qoriq-restool-lf-6.12.20-2.0.0.tar.gz
> +sha256  
> 68f4b15ecc085729419bc60ca6eeadca5af0237bbfec791e8a79da9c943d42e9  
> LICENSE
> diff --git a/package/qoriq-restool/qoriq-restool.mk 
> b/package/qoriq-restool/qoriq-restool.mk
> new file mode 100644
> index 000000000000..2e02e00cdb1c
> --- /dev/null
> +++ b/package/qoriq-restool/qoriq-restool.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# qoriq-restool
> +#
> +################################################################################
> +
> +QORIQ_RESTOOL_VERSION = lf-6.12.20-2.0.0
> +QORIQ_RESTOOL_SITE = $(call 
> github,nxp-qoriq,restool,$(QORIQ_RESTOOL_VERSION))
> +QORIQ_RESTOOL_LICENSE = BSD-3-Clause or GPL-2.0-or-later
> +QORIQ_RESTOOL_LICENSE_FILES = COPYING
> +
> +QORIQ_RESTOOL_MAKE_OPTS = \
> +	CC="$(TARGET_CC)" \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +
> +define QORIQ_RESTOOL_BUILD_CMDS
> +	cd $(@D) && $(TARGET_MAKE_ENV) $(MAKE) $(QORIQ_RESTOOL_MAKE_OPTS)
> +endef
> +
> +define QORIQ_RESTOOL_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) MANPAGE="" $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) 
> \
> +		prefix=/usr install
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.43.0

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot