Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

On 10.10.2016 15:41, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
> 
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> 
> v2:
> - Updated some documentation in docs/qmp-commands.txt and
>   qapi/block-core.json [Max]

In qmp-commands.txt, there is still a blockdev-add example with
"options" under x-blockdev-change, and the blockdev-add documentation
itself still says that blockdev-add takes an argument named "options".

Max

>  docs/qmp-commands.txt  |  72 ++++++++++++++----------------
>  qapi/block-core.json   |   4 +-
>  tests/qemu-iotests/041 |  11 +++--
>  tests/qemu-iotests/067 |  12 +++--
>  tests/qemu-iotests/071 | 118 +++++++++++++++++++++----------------------------
>  tests/qemu-iotests/081 |  52 ++++++++++------------
>  tests/qemu-iotests/085 |   9 ++--
>  tests/qemu-iotests/087 |  76 +++++++++++++------------------
>  tests/qemu-iotests/117 |  12 ++---
>  tests/qemu-iotests/118 |  42 +++++++++---------
>  tests/qemu-iotests/124 |  20 ++++-----
>  tests/qemu-iotests/139 |  10 ++---
>  tests/qemu-iotests/141 |  13 +++---
>  tests/qemu-iotests/155 |  10 ++---
>  14 files changed, 209 insertions(+), 252 deletions(-)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 480 bytes --]