From: Juergen Gross <jgross@suse.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH 1/2] xenstore: free resp in do_control_help
Date: Wed, 1 Mar 2017 12:14:14 +0100 [thread overview]
Message-ID: <bb192af8-004c-de3d-327f-c1069ce99ae7@suse.com> (raw)
In-Reply-To: <20170301110702.30253-1-wei.liu2@citrix.com>
On 01/03/17 12:07, Wei Liu wrote:
> Coverity-ID: 1401603
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> ---
> tools/xenstore/xenstored_control.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
> index 7c149117b1..d99b7eb7f9 100644
> --- a/tools/xenstore/xenstored_control.c
> +++ b/tools/xenstore/xenstored_control.c
> @@ -171,6 +171,8 @@ static int do_control_help(void *ctx, struct connection *conn,
> resp[len] = 0;
>
> send_reply(conn, XS_CONTROL, resp, len);
> +
> + talloc_free(resp);
Sorry, no. The context for the allocation is "in" which will be freed
automatically.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-01 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:07 [PATCH 1/2] xenstore: free resp in do_control_help Wei Liu
2017-03-01 11:14 ` Juergen Gross [this message]
2017-03-01 11:17 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb192af8-004c-de3d-327f-c1069ce99ae7@suse.com \
--to=jgross@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.