From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BF3BE77198 for ; Mon, 6 Jan 2025 09:08:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.865575.1276813 (Exim 4.92) (envelope-from ) id 1tUj5b-0003cP-WE; Mon, 06 Jan 2025 09:08:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 865575.1276813; Mon, 06 Jan 2025 09:07:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tUj5b-0003cI-T8; Mon, 06 Jan 2025 09:07:59 +0000 Received: by outflank-mailman (input) for mailman id 865575; Mon, 06 Jan 2025 09:07:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tUj5a-0003bw-CR for xen-devel@lists.xenproject.org; Mon, 06 Jan 2025 09:07:58 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b85ff077-cc0d-11ef-a0df-8be0dac302b0; Mon, 06 Jan 2025 10:07:57 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-38637614567so6377969f8f.3 for ; Mon, 06 Jan 2025 01:07:57 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a28f17315sm41944822f8f.108.2025.01.06.01.07.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 01:07:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b85ff077-cc0d-11ef-a0df-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736154477; x=1736759277; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=USpGyjrA+JrNjT+NfIaQhGg7WBh5lnUT4kfannP2Jhw=; b=czLSgaN28zXl1+d5O8JHiKvqJQdXeHJMdh/zRa9ARp15fTml7ElTBR9x2NMfhEXyWO QSw1KpeTAagD+qN7iuFti9Vl+iOeNiVN01Rrm5PrDCoqjx1AO1n7KrToNs1GpTgHukBi rE+O4885ej90S7pUK71kT2yYBz0UQszhIwnF4YhSv1Yxm/ocb3oqjESUN6fzavC6L625 NBGmVm9UfV8GTMhmCfdhG5mURr7E+nyXQuaObCxhxzb9cbmkcBFqnz61mWDSb/xIMS5i 2Six/DpJU2egRkhaivbvuEuIgvRSMPikzZ3uVhwqpKJTFX3NpmeXd2qEkvaugVSbOljj k2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736154477; x=1736759277; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=USpGyjrA+JrNjT+NfIaQhGg7WBh5lnUT4kfannP2Jhw=; b=xBEytRfM2dDyx6Ij8ZfBn3d9KZTKGqPygMRVnZzV4mB70OxcfZTBQ4/LvkmAAxFLUJ 0+jrhm+c+PD5qy3Lq69bVmO8vGsrdCWRvAo8dQt2PyGdrFaRLyzHJDUziQnqgt/OmZTp prhh0foqHAmNbKz6VqIJQ0wbNTanjE0Wo6PzcD1qzbc+9IV3ZUzg1eJP+BMQnBSWy2I2 3vgVNPoCZRJuDLTNE4sLrKWIVLLzuhtVxyJy4DqXfZiaE8Z3LaA/XyoqUVig00UoLDqW zxRLuFHfp5Aeo1Gl6XNfV3rBO4yEfKMbWEC7bSTKtffkci97y/FgOkJ2AOl8AtbAnNN+ G8Xg== X-Forwarded-Encrypted: i=1; AJvYcCWoEwbht8pr7SPPQoPDotaiZsXI09hGtRAx6TqfL8rAQKKQYpVNXXfK6WyojrV4cx2htYueO4y14UY=@lists.xenproject.org X-Gm-Message-State: AOJu0YzgX0XjEIYTkraJO/yJnvxLJtUaDUPv+g9jfR7TtvpplLKHUVjJ mt0TG47+RQ3Lx84Q+fJ2ATzB3YQ/trwzJZl5oy/sIe1dl5LTyTRNSNVxEPsNTA== X-Gm-Gg: ASbGnct3sSI6fbIEsfwYac/bcBcDyc0BLM1lzAgfHAgfaNj7Yjw5x1qdLzAuKRyKeQv gWS32RSlqGdMzv27dQPYnAdlPu/VnDB4FqxHKg9es9PR4Ri3rkH/046gLiCQDGRLJ/Mm9nI/OCP JGXSbeRMiB3vqeKAfhuGf3D1+tz3JdN+5hESh9zV0ix6+N4XzjeMyFcLiysNqJ/8v5xZGeQPgpE /pirPlvrFPZuZulU67Z07V5UgKB9FTlimJ66FZySmck7GWKjbWqNglLbAWNqTxzj00E/teEskJx 5usPHmKlaujGM/AxvRhuqOkzmN7V0aGpQsiDa+InFA== X-Google-Smtp-Source: AGHT+IFO88iORJObK8PzgZyJivBj38Z36lAxRvVm1XyweSU86HhFkFeU1UHHr5Uc3kLMWUM1SNcS6g== X-Received: by 2002:a5d:64c9:0:b0:385:f17b:de54 with SMTP id ffacd0b85a97d-38a221f11f9mr53624643f8f.5.1736154476767; Mon, 06 Jan 2025 01:07:56 -0800 (PST) Message-ID: Date: Mon, 6 Jan 2025 10:08:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/35] xen/console: introduce console_set_owner() To: Denis Mukhin Cc: dmukhin@ford.com, Andrew Cooper , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20241205-vuart-ns8250-v1-0-e9aa923127eb@ford.com> <20241205-vuart-ns8250-v1-19-e9aa923127eb@ford.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04.01.2025 04:07, Denis Mukhin wrote: > On Tuesday, December 10th, 2024 at 7:02 AM, Jan Beulich wrote: >> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: >>> +int console_set_owner(domid_t domid) >> >> >> static? Iirc Misra doesn't like non-static functions which aren't called >> from any other CU. > > Yes, but there's a follow on patch which will undo static - hwdom_crashconsole= > patch - to drop the user to xen console once dom0 has crashed. > So since there's a need in globally visible symbol, I decided to get rid of static > right away. Yet you realize that any series may go in piecemeal, and therefore no Misra rule may be violated at any patch boundary? Jan