From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: shao.mingyin@zte.com.cn, linusw@kernel.org, brgl@kernel.org,
linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, geert+renesas@glider.be,
wbg@kernel.org, opendmb@gmail.com,
florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, jelonek.jonas@gmail.com
Subject: Re: [PATCH 2/5] gpio: aspeed-sgpio: propagate IRQ setup error in probe
Date: Mon, 09 Nov 2026 14:25:39 +1030 [thread overview]
Message-ID: <bb201e889665f2b5c9ac356674091b183de06aba.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20261107161254042rp3ZKRkQGz2jfH-FBrmtg@zte.com.cn>
On Sat, 2026-11-07 at 16:12 +0800, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> aspeed_sgpio_probe() ignores the return value of
> aspeed_sgpio_setup_irqs(). That function returns the result of
> platform_get_irq(), so on failure - in particular -EPROBE_DEFER while
> the parent interrupt controller is still probing - the driver carries on
> and registers the gpiochip with no interrupt support, and the deferred
> probe is never retried, leaving GPIO interrupts permanently broken.
>
> The "interrupts" property is mandatory for this device, so propagate the
> error from probe.
>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
next prev parent reply other threads:[~2026-11-09 3:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 8:12 [PATCH 0/5] gpio: fix IRQ handling and probe error paths in five drivers shao.mingyin
2026-11-07 8:12 ` [PATCH 1/5] gpio: rcar: don't clobber INTMSK when disabling a single line shao.mingyin
2026-11-09 14:40 ` Geert Uytterhoeven
2026-11-09 14:57 ` shao.mingyin
2026-11-07 8:12 ` [PATCH 2/5] gpio: aspeed-sgpio: propagate IRQ setup error in probe shao.mingyin
2026-11-09 3:55 ` Andrew Jeffery [this message]
2026-11-07 8:12 ` [PATCH 3/5] gpio: 104-idi-48: fix max_register blocking the IRQ register shao.mingyin
2026-11-07 20:19 ` William Breathitt Gray
2026-11-07 8:12 ` [PATCH 4/5] gpio: brcmstb: don't turn platform_get_irq errors into -ENOENT shao.mingyin
2026-11-10 4:39 ` Florian Fainelli
2026-11-07 8:12 ` [PATCH 5/5] gpio: line-mux: fix unsigned truncation of property count error shao.mingyin
2026-11-09 8:29 ` Jonas Jelonek
2026-11-09 10:21 ` shao.mingyin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb201e889665f2b5c9ac356674091b183de06aba.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=jelonek.jonas@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=shao.mingyin@zte.com.cn \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.