From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86/boot: Fix include paths for 32bit objects
Date: Wed, 4 Sep 2024 09:05:04 +0100 [thread overview]
Message-ID: <bb31e4ab-ba0f-445c-8564-0758297f9985@citrix.com> (raw)
In-Reply-To: <26b84bfa-e186-4b07-8718-72a10be8b03c@suse.com>
On 04/09/2024 7:54 am, Jan Beulich wrote:
> On 03.09.2024 13:53, Andrew Cooper wrote:
>> Most of Xen is build using -nostdinc and a fully specified include path.
>> However, the makefile line:
>>
>> $(head-bin-objs): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
>>
>> discards XEN_CFLAGS and replaces them with CFLAGS_x86_32.
>>
>> Reinstate -nostdinc, and copy all -I (and -Wa,-I) arguments from XEN_CFLAGS.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Despite the title saying "Fix" I take the absence of a Fixes: tag as meaning
> that this won't need backporting, and is rather only needed for what went on
> top.
Oh sorry. v1 had a Fixes tag, and then Anthony objected.
"x86/boot: Use <xen/types.h>" is where it breaks properly without this
patch, so I don't think there's a specific need to backport.
~Andrew
prev parent reply other threads:[~2024-09-04 8:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 10:49 [PATCH] x86/boot: Reinstate -nostdinc for CFLAGS_x86_32 Andrew Cooper
2024-09-03 10:54 ` Roger Pau Monné
2024-09-03 11:08 ` Andrew Cooper
2024-09-03 11:16 ` Andrew Cooper
2024-09-03 12:16 ` Roger Pau Monné
2024-09-03 11:20 ` Anthony PERARD
2024-09-03 11:51 ` Andrew Cooper
2024-09-03 12:19 ` Roger Pau Monné
2024-09-03 11:53 ` [PATCH v2] x86/boot: Fix include paths for 32bit objects Andrew Cooper
2024-09-03 12:43 ` Roger Pau Monné
2024-09-03 13:01 ` Andrew Cooper
2024-09-03 13:08 ` Roger Pau Monné
2024-09-03 14:32 ` Jan Beulich
2024-09-03 14:33 ` Andrew Cooper
2024-09-03 14:50 ` Andrew Cooper
2024-09-04 6:54 ` Jan Beulich
2024-09-04 8:05 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb31e4ab-ba0f-445c-8564-0758297f9985@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.