All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Guixiong Wei <weiguixiong@bytedance.com>
Cc: <x86@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] x86/fpu: Fix memory leak with dynamic fpstate and exec()
Date: Tue, 20 Oct 2026 11:21:02 -0700	[thread overview]
Message-ID: <bb50436d-8af6-4420-b626-97f262f6759d@intel.com> (raw)
In-Reply-To: <451788d5e97cba38274e663d2b7952c593e959be.299fa9aa.210c.4b1f.9ab7.7acb67f42a19@bytedance.com>

On 10/19/2026 6:49 PM, Guixiong Wei wrote:
> 
>      void fpstate_free(struct fpu *fpu)
>      {
>              __fpstate_free(fpu->fpstate);
>      }

Hmm, just curious why the original check has to be removed. I thought 
this sanity check from the struct fpu context was reasonable, no?

   void fpstate_free(struct fpu *fpu)
   {
       if (fpu->fpstate && fpu->fpstate != &fpu->__fpstate)
            __fpstate_free(fpu->fpstate);
   }

Thanks,
Chang

  reply	other threads:[~2026-10-20 18:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  5:59 [PATCH v2 0/2] x86/fpu: Fix dynamic fpstate leak on exec() Guixiong Wei
2026-10-08  5:59 ` [PATCH v2 1/2] x86/fpu: Fix memory leak with dynamic fpstate and exec() Guixiong Wei
2026-10-15  0:19   ` Chang S. Bae
2026-10-19 17:53     ` Chang S. Bae
2026-10-20  1:49       ` Guixiong Wei
2026-10-20 18:21         ` Chang S. Bae [this message]
2026-10-26  2:10           ` Guixiong Wei
2026-10-27  0:31             ` Chang S. Bae
2026-10-20  1:28     ` Guixiong Wei
2026-10-08  5:59 ` [PATCH v2 2/2] selftests/x86/amx: Test dynamic fpstate cleanup across exec() Guixiong Wei
2026-10-15  0:19   ` Chang S. Bae
2026-10-20  1:59     ` Guixiong Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb50436d-8af6-4420-b626-97f262f6759d@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=weiguixiong@bytedance.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.